Patch 697: Resolve issue2135: Don't keep trying to annotate a fil... - Darcs bug tracker

Title	Resolve issue2135: Don't keep trying to annotate a fil...
Superseder		Nosy List	owst
Related Issues
Status	accepted	Assigned To	owst
Milestone

Created on 2012-01-22.04:12:23 by owst, last changed 2012-03-19.21:10:57 by gh.

Files
File name	Status	Uploaded	Type	Edit	Remove
patch-preview.txt		owst, 2012-01-22.04:12:22	text/x-darcs-patch
resolve-issue2135_-don_t-keep-trying-to-annotate-a-file_-after-processing-the-patch-that-added-the-file_.dpatch		owst, 2012-01-22.04:12:22	application/x-darcs-patch
unnamed		owst, 2012-01-22.04:12:22

See mailing list archives for discussion on individual patches.

Messages
msg15047 (view)	Author: owst	Date: 2012-01-22.04:12:22
1 patch for repository http://darcs.net: Sun Jan 22 04:14:38 GMT 2012 Owen Stephens <darcs@owenstephens.co.uk> * Resolve issue2135: Don't keep trying to annotate a file, after processing the patch that added the file. Attachments patch-preview.txt resolve-issue2135_-don_t-keep-trying-to-annotate-a-file_-after-processing-the-patch-that-added-the-file_.dpatch unnamed
msg15317 (view)	Author: gh	Date: 2012-03-14.17:47:45
Following an IRC discussion ( http://irclog.perlgeek.de/darcs/2012-03-13#i_5283168 ), and the fact that the "unknown" annotation can appear also with files when annotating directories ( see issue2154 ), I would suggest Owen roll backs this patch, and that we try to tackle the root of this problem. That is, seeing to it that all lines always end up annotated at the moment we reach the patch that added a given file.
msg15360 (view)	Author: gh	Date: 2012-03-19.21:10:57
Sent a rollback ( patch759 )

History
Date	User	Action	Args
2012-01-22 04:12:23	owst	create
2012-02-22 21:00:36	ganesh	set	status: needs-screening -> needs-review
2012-03-14 17:47:45	gh	set	messages: + msg15317
2012-03-15 22:55:21	mndrix	set	status: needs-review -> followup-requested assignedto: owst
2012-03-19 21:10:57	gh	set	status: followup-requested -> accepted messages: + msg15360