Patch 735: Tidy up and Haddock Non. Rename some functions in Non ... - Darcs bug tracker

Title	Tidy up and Haddock Non. Rename some functions in Non ...
Superseder		Nosy List	owst
Related Issues
Status	accepted	Assigned To
Milestone

Created on 2012-03-01.02:15:35 by owst, last changed 2012-03-24.16:07:36 by gh.

Files
File name	Status	Uploaded	Type	Edit	Remove
patch-preview.txt		owst, 2012-03-01.02:15:34	text/x-darcs-patch
tidy-up-and-haddock-non_-rename-some-functions-in-non-and-correspondingn-use_sites-in-real.dpatch		owst, 2012-03-01.02:15:34	application/x-darcs-patch
unnamed		owst, 2012-03-01.02:15:34

See mailing list archives for discussion on individual patches.

Messages
msg15196 (view)	Author: owst	Date: 2012-03-01.02:15:34
I've quite extensively shuffled/renamed/commented Non, hopefully it's a bit easier to understand now... 1 patch for repository http://darcs.net: Thu Mar 1 02:19:49 GMT 2012 Owen Stephens <darcs@owenstephens.co.uk> * Tidy up and Haddock Non. Rename some functions in Non and correspondingn use-sites in Real Attachments patch-preview.txt tidy-up-and-haddock-non_-rename-some-functions-in-non-and-correspondingn-use_sites-in-real.dpatch unnamed
msg15390 (view)	Author: mndrix	Date: 2012-03-23.21:40:16
Thanks for documenting and cleaning that code. I don't understand all the details, but the comments and new names certainly clarified the high level purpose. Committers, please push the patch. > hunk ./src/Darcs/Patch/V2/Non.hs > +-- TODO: Figure out what remNons is for; it's is only used in one place - when s/it's is/it's/ Whichever patch addresses the TODO can correct the typo at the same time.
msg15394 (view)	Author: gh	Date: 2012-03-24.16:07:36
Done.

History
Date	User	Action	Args
2012-03-01 02:15:35	owst	create
2012-03-01 07:24:48	ganesh	set	status: needs-screening -> needs-review
2012-03-23 21:40:16	mndrix	set	status: needs-review -> accepted-pending-tests messages: + msg15390
2012-03-24 16:07:36	gh	set	status: accepted-pending-tests -> accepted messages: + msg15394