Patch 805: Tidy Repository.Format (and 2 more) - Darcs bug tracker

Created on 2012-04-17.12:05:29 by owst, last changed 2012-04-24.13:39:51 by gh.

Files
File name	Status	Uploaded	Type	Edit	Remove
patch-preview.txt		owst, 2012-04-17.12:05:29	text/x-darcs-patch
tidy-repository_format.dpatch		owst, 2012-04-17.12:05:29	application/x-darcs-patch
unnamed		owst, 2012-04-17.12:05:29

See mailing list archives for discussion on individual patches.

Messages
msg15570 (view)	Author: owst	Date: 2012-04-17.12:05:29
General tidy-up of Repository.Format, followed by a refactor to parse the format strings once, and store the result using an ADT. This prevents the need to do so many dubious String->ADT->String conversions. 3 patches for repository http://darcs.net: Fri Apr 13 01:59:10 BST 2012 Owen Stephens <darcs@owenstephens.co.uk> * Tidy Repository.Format Tue Apr 17 09:02:38 BST 2012 Owen Stephens <darcs@owenstephens.co.uk> * More tidying of Repository.Format Tue Apr 17 13:03:09 BST 2012 Owen Stephens <darcs@owenstephens.co.uk> * Parse RepoFormat properties once, storing as an ADT, rather than a ByteString. We used to have to do various conversions to/from ByteStrings, which seems unclean and less safe. Attachments patch-preview.txt tidy-repository_format.dpatch unnamed
msg15571 (view)	Author: owst	Date: 2012-04-17.22:54:03
Self-accepting; I'd like someone to just check over the last patch. I think the shell tests are pretty good for this module, so am confident I've not broken things.
msg15612 (view)	Author: gh	Date: 2012-04-24.13:39:51
Last patch seems correct and is an improvement. Stores format as list of Strings and always works with that. Accepted.

History
Date	User	Action	Args
2012-04-17 12:05:29	owst	create
2012-04-17 22:54:03	owst	set	status: needs-screening -> needs-review messages: + msg15571
2012-04-24 13:39:51	gh	set	status: needs-review -> accepted messages: + msg15612