Seems fairly reasonable, not really reviewed, but I think I more or less
understand what's going on.
UI-wise, this might be a bit confusing. I wonder if
--dont-allow-conflicts,
--no-allow-conflicts fail if...
Needs to be maybe vertically aligned with the top rather than bottom.
Perhaps we could establish a convention where one of these is displayed
and the others are just hidden from help? (ie. just there for backwards
compatibility? In the above case, we probably want to keep no-allow-
conflicts
Marc, things to address in a follow-up patch before we push this to
reviewed (I'm pushing this to screened, ie. http://darcs.net though):
- hlint (if not already)
- coding style, see http://wiki.darcs.net/Development/CodingStyle
(there's a link to a GitHub page with indentation conventions, etc)
- perhaps nuke some partial functions if there's a sane way to do it
(last, init, head). It's low risk here — the worst is darcs help blows
up — but in general I like to avoid them if I can. Any way we can
improve that?
- I think replace sepBy and maybe unlines' with some use of intercalate
or intersperse?
- Copyright header (may need to grab from GetOpt code)
(And thanks for the haddocked code!)
|