Patch 836: resolve issue2198 move repo testing code to Darcs.Repo... - Darcs bug tracker

Title	resolve issue2198 move repo testing code to Darcs.Repo...
Superseder		Nosy List	gh
Related Issues
Status	accepted	Assigned To
Milestone

Created on 2012-05-30.20:25:28 by gh, last changed 2012-05-31.23:07:16 by owst.

Files
File name	Status	Uploaded	Type	Edit	Remove
patch-preview.txt		gh, 2012-05-30.20:25:27	text/x-darcs-patch
resolve-issue2198-move-repo-testing-code-to-darcs_repository_test.dpatch		gh, 2012-05-30.20:25:28	application/x-darcs-patch
unnamed		gh, 2012-05-30.20:25:28

See mailing list archives for discussion on individual patches.

Messages
msg15738 (view)	Author: gh	Date: 2012-05-30.20:25:28
Move testing code to a new Darcs.Repository.Test (from Darcs.Test). I had to make Darc.Arguments stop importing Darcs.Repository, by moving the following functions to Darcs.Repository or Darcs.Repository.Internal makeScriptsExecutable listRegisteredFiles listUnregisteredFiles listFiles In particular I feel that it's important that the file listing functions belong to Darcs.Repository for the library users, since it seems like basic repository-related functions. And that change reduces a little the beast that is Darcs.Arguments. As almost all modules Darcs.Commands.* relied on listRegisteredFiles or listFiles, I had to change their imports. 1 patch for repository http://darcs.net: Sat May 26 18:07:46 ART 2012 Guillaume Hoffmann <guillaumh@gmail.com> * resolve issue2198 move repo testing code to Darcs.Repository.Test also move (versioned and unversioned) file listing functions from Darcs.Arguments to Darcs.Repository to avoid circular dependencies. Attachments patch-preview.txt resolve-issue2198-move-repo-testing-code-to-darcs_repository_test.dpatch unnamed
msg15778 (view)	Author: owst	Date: 2012-05-31.22:59:09
Looks good, thanks.
msg15781 (view)	Author: owst	Date: 2012-05-31.23:07:16
Looks good, thanks!

History
Date	User	Action	Args
2012-05-30 20:25:28	gh	create
2012-05-30 21:41:28	ganesh	set	status: needs-screening -> needs-review
2012-05-31 22:59:09	owst	set	status: needs-review -> accepted messages: + msg15778
2012-05-31 23:07:16	owst	set	messages: + msg15781