Patch 868: use nubSort function from data-ordlist instead of own - Darcs bug tracker

Title	use nubSort function from data-ordlist instead of own
Superseder		Nosy List	gh
Related Issues
Status	accepted	Assigned To
Milestone

Created on 2012-06-30.02:29:06 by gh, last changed 2012-07-02.00:47:02 by gh.

Files
File name	Status	Uploaded	Type	Edit	Remove
patch-preview.txt		gh, 2012-06-30.02:29:06	text/x-darcs-patch
remove-pullrepo-from-darcs-locations_.dpatch		kowey, 2012-07-01.18:08:24	application/octet-stream
unnamed		gh, 2012-06-30.02:29:06
use-nubsort-function-from-data_ordlist-instead-of-own.dpatch		gh, 2012-06-30.02:29:06	application/x-darcs-patch

See mailing list archives for discussion on individual patches.

Messages
msg15838 (view)	Author: gh	Date: 2012-06-30.02:29:06
1 patch for repository http://darcs.net: Sat Jun 23 22:29:33 ART 2012 Guillaume Hoffmann <guillaumh@gmail.com> * use nubSort function from data-ordlist instead of own Attachments patch-preview.txt unnamed use-nubsort-function-from-data_ordlist-instead-of-own.dpatch
msg15843 (view)	Author: kowey	Date: 2012-07-01.15:15:59
Looks fine. data-ordlist seems not to introduce any dependencies of its own; and it doesn't introduce new assumptions. I have some concerns about it. This package is neither particularly trusted (it's not eg. in the Haskell Platform), nor has it been reviewed, nor does it come with any tests. It's not like we've been holding up packages to any sort of standard in the past, but it seems like we should be making a little bit of effort about them. Ideally, I guess we would insist on having some QuickChecks for the data-ordlist nubSort functions before we pushed this patch to reviewed.
msg15844 (view)	Author: kowey	Date: 2012-07-01.18:08:24
Ah-hah! there are tests for data-ordlist! I've sent Leon a small patch making his tests more visible. Attachments remove-pullrepo-from-darcs-locations_.dpatch
msg15846 (view)	Author: gh	Date: 2012-07-02.00:47:01
Thanks for catching that, Eric. I agree we should write our own QC for the third-party functions we use if this isn't already done by the provider. g.

History
Date	User	Action	Args
2012-06-30 02:29:06	gh	create
2012-06-30 02:29:50	gh	set	status: needs-screening -> needs-review
2012-07-01 15:16:00	kowey	set	status: needs-review -> accepted-pending-tests messages: + msg15843
2012-07-01 18:08:24	kowey	set	files: + remove-pullrepo-from-darcs-locations_.dpatch messages: + msg15844
2012-07-01 18:16:59	kowey	set	status: accepted-pending-tests -> accepted
2012-07-02 00:47:02	gh	set	messages: + msg15846