Patch 898: Style/Tidy Cache.hs (and 7 more) - Darcs bug tracker

Created on 2012-08-12.22:04:09 by owst, last changed 2012-09-29.22:25:18 by darcswatch. Tracked on DarcsWatch.

Files
File name	Status	Uploaded	Type	Edit	Remove
fix-darcsden_breaking-regression-due-to-cache-do_block-tweak.dpatch		ganesh, 2012-08-25.21:53:02	text/x-darcs-patch
patch-preview.txt		owst, 2012-08-12.22:04:09	text/x-darcs-patch
style_tidy-cache_hs.dpatch		owst, 2012-08-12.22:04:09	application/x-darcs-patch
unnamed		owst, 2012-08-12.22:04:09
unnamed		ganesh, 2012-08-25.21:53:02

See mailing list archives for discussion on individual patches.

Messages
msg15972 (view)	Author: owst	Date: 2012-08-12.22:04:09
A bunch of tidying for the Cache module 8 patches for repository http://darcs.net: Sun Aug 12 19:13:53 BST 2012 Owen Stephens <darcs@owenstephens.co.uk> * Style/Tidy Cache.hs Sun Aug 12 19:35:23 BST 2012 Owen Stephens <darcs@owenstephens.co.uk> * Camel case isthisrepo in Cache Sun Aug 12 19:49:57 BST 2012 Owen Stephens <darcs@owenstephens.co.uk> * Use a Show instance rather than hashedDir function for HashedDir -> String Sun Aug 12 20:50:43 BST 2012 Owen Stephens <darcs@owenstephens.co.uk> * Remove some uses of ++ "/" where </> is more appropriate Sun Aug 12 21:00:44 BST 2012 Owen Stephens <darcs@owenstephens.co.uk> * Simplify Eq instance for CacheLoc Sun Aug 12 22:19:52 BST 2012 Owen Stephens <darcs@owenstephens.co.uk> * Simplify checkCacheReachability function Sun Aug 12 22:34:59 BST 2012 Owen Stephens <darcs@owenstephens.co.uk> * Remove duplicate 'fn' function and do some CSE in Cache Sun Aug 12 22:54:53 BST 2012 Owen Stephens <darcs@owenstephens.co.uk> * Tweak a nested do-block in Cache for improved readability Attachments patch-preview.txt style_tidy-cache_hs.dpatch unnamed
msg15976 (view)	Author: kowey	Date: 2012-08-18.09:24:34
Stylistic nitpick: I have some doubts about using Show as a catch-all “make this a String” function. I get the impression that actually Show should try to produce a reasonable Haskell representation of your data. It could be that so few people respect this that it's not worth trying to do it (something about barn doors and horses?). For my own stuff I'd taken to ripping out my human-friendly Show instances and replacing them with a Pretty typeclass. I forget why exactly I care about this, I think partly that the Haskell-y-not-people-friendly Show stuff does get pretty convenient for debugging. Show aside, I think we also want to be careful that we don't accidentally use show-for-humans functions outside the context of talking to users. If it so happens that the human-friendly representation is the same as the real-effects representation, then we should define show in terms of the real-effects one (so show = hashedDir in this case)
msg15999 (view)	Author: gh	Date: 2012-08-22.18:05:40
I'm screening all patches except "Use a Show instance rather than hashedDir function for HashedDir -> String" and "Remove some uses of ++ "/" where </> is more appropriate" which I'm also not sure of and I suggest rejecting. Everything compiles, passes tests and looks fine. If there is no further discussion about this bundle I'll simply accept it in a few days.
msg16012 (view)	Author: ganesh	Date: 2012-08-25.21:53:02
1 patch for repository /home/ganesh/darcs/darcs-screened-temp: Sat Aug 25 22:27:22 BST 2012 Simon Michael <simon@joyful.com> * fix darcsden-breaking regression due to Cache do-block tweak Attachments fix-darcsden_breaking-regression-due-to-cache-do_block-tweak.dpatch unnamed
msg16013 (view)	Author: darcswatch	Date: 2012-08-25.21:53:38
This patch bundle (with 1 patches) was just applied to the repository http://darcs.net/screened. This message was brought to you by DarcsWatch http://darcswatch.nomeata.de/repo_http:__darcs.net_screened.html#bundle-e04e34e1c2d3fd64a129cc4ae2f18b6d56084ee7
msg16169 (view)	Author: owst	Date: 2012-09-29.22:08:03
Accepted the patches agreed on by Guillaume, and the extra fixup from Simon.
msg16176 (view)	Author: darcswatch	Date: 2012-09-29.22:25:18
This patch bundle (with 1 patches) was just applied to the repository http://darcs.net/reviewed. This message was brought to you by DarcsWatch http://darcswatch.nomeata.de/repo_http:__darcs.net_reviewed.html#bundle-e04e34e1c2d3fd64a129cc4ae2f18b6d56084ee7

History
Date	User	Action	Args
2012-08-12 22:04:09	owst	create
2012-08-18 09:24:35	kowey	set	messages: + msg15976
2012-08-22 18:05:41	gh	set	status: needs-screening -> needs-review messages: + msg15999
2012-08-25 21:53:02	ganesh	set	files: + fix-darcsden_breaking-regression-due-to-cache-do_block-tweak.dpatch, unnamed messages: + msg16012
2012-08-25 21:53:38	darcswatch	set	messages: + msg16013
2012-08-25 21:53:38	darcswatch	set	darcswatchurl: http://darcswatch.nomeata.de/repo_http:__darcs.net_reviewed.html#bundle-e04e34e1c2d3fd64a129cc4ae2f18b6d56084ee7
2012-09-29 22:08:03	owst	set	status: needs-review -> accepted messages: + msg16169
2012-09-29 22:25:18	darcswatch	set	messages: + msg16176