Patch 919: Add rts flag to cabal - Darcs bug tracker

Created on 2012-08-26.17:05:19 by bsrkaditya, last changed 2012-11-02.09:46:43 by darcswatch. Tracked on DarcsWatch.

Files
File name	Status	Uploaded	Type	Edit	Remove
add-flag-rts-to-cabal.dpatch		bsrkaditya, 2012-08-26.17:05:18	application/octet-stream

See mailing list archives for discussion on individual patches.

Messages
msg16026 (view)	Author: bsrkaditya	Date: 2012-08-26.17:05:18
This patch is a followup to the patch index patch (patch918). rts is necceary because darcs runs out of stack when building patch index on ghc sized repositories. Attachments add-flag-rts-to-cabal.dpatch
msg16027 (view)	Author: darcswatch	Date: 2012-08-26.18:45:46
This patch bundle (with 1 patches) was just applied to the repository http://darcs.net/screened. This message was brought to you by DarcsWatch http://darcswatch.nomeata.de/repo_http:__darcs.net_screened.html#bundle-0e494fd312df3de6d4a532d9e63366bf75e2bdb0
msg16183 (view)	Author: owst	Date: 2012-09-29.22:42:42
Depends on PI
msg16252 (view)	Author: markstos	Date: 2012-10-20.02:15:17
What kind of test is this pending? (manual or automated). In my own manually testing I found I also needed the "RTS" flag build the patch index, and using this newly supplied option to "cabal install" indeed worked. I don't understand why the necessary settings aren't already the default, but that's beyond the scope of this ticket.
msg16254 (view)	Author: ganesh	Date: 2012-10-20.17:23:56
"accepted-pending-tests" means "this patch has been reviewed so if the tests pass with this patch applied then it's ok to push to reviewed". A lot of patches can languish in this state for a while because they depend on other patches that haven't yet been reviewed. FYI, RTS flags are disabled by GHC by default because there's a possibility of them being an unexpected security hole - you can use them to write to an arbitrary file on disk, which could be a problem for a binary that is being used in a security-sensitive setting such as being a CGI script. In the case of darcs we couldn't quite convince ourselves that this wouldn't be an issue - e.g. it gets invoked remotely to apply patches - so the current position is to play it safe. I'm not really confident it's the right approach though.
msg16285 (view)	Author: darcswatch	Date: 2012-11-02.09:46:43
This patch bundle (with 1 patches) was just applied to the repository http://darcs.net/reviewed. This message was brought to you by DarcsWatch http://darcswatch.nomeata.de/repo_http:__darcs.net_reviewed.html#bundle-0e494fd312df3de6d4a532d9e63366bf75e2bdb0

History
Date	User	Action	Args
2012-08-26 17:05:19	bsrkaditya	create
2012-08-26 17:07:13	darcswatch	set	darcswatchurl: http://darcswatch.nomeata.de/repo_http:__darcs.net_reviewed.html#bundle-0e494fd312df3de6d4a532d9e63366bf75e2bdb0
2012-08-26 18:45:46	darcswatch	set	status: needs-screening -> needs-review messages: + msg16027
2012-09-29 22:42:42	owst	set	status: needs-review -> accepted-pending-tests messages: + msg16183
2012-10-20 02:15:17	markstos	set	messages: + msg16252
2012-10-20 17:23:57	ganesh	set	messages: + msg16254
2012-11-02 09:27:44	galbolle	set	status: accepted-pending-tests -> accepted
2012-11-02 09:46:43	darcswatch	set	messages: + msg16285