Sun Nov 22 00:26:31 CET 2009  caitt@users.sourceforge.net
  * resolve issue1392: use parsec to parse .authorspelling
  .authorspelling file is now parsed using parsec.
  Parser reports errors (only affected line is discarded).
  Added escaping of commas.

Attachments

• resolve-issue1392_-use-parsec-to-parse-_authorspelling.dpatch
• unnamed

This patch bundle (with 1 patch), which can be  applied to the repository http://darcs.net/ is now tracked  on DarcsWatch at http://darcswatch.nomeata.de/repo_http:__darcs.net_.html

I think this looks good. As it completely changes the handling of
.authorspellings, could you confirm that you expect it to be
backwards-compatible with old .authorspellings files. Also I guess you've tested
it on at least the darcs repo's .authorspellings file - any others?

2009/12/6 Ganesh Sittampalam <bugs@darcs.net>:
>
> Ganesh Sittampalam <ganesh@earth.li> added the comment:
>
> I think this looks good. As it completely changes the handling of
> .authorspellings, could you confirm that you expect it to be
> backwards-compatible with old .authorspellings files. Also I guess you've tested
> it on at least the darcs repo's .authorspellings file - any others?
>

Yes, I am expecting the changes to be backwards-compatible and I have
tested them on darcs repo only.

The only difference other than handling commas should be requiring
email (anything in angle brackets) in the canonical part of line. My
understanding is that original docs required that too, but
implementation did not (there is no such line in darcs repo
.authorspelling file). Dunno if it was a feature or a bug :-).

-- 
Tomas Caithaml

Don't anthropomorphize computers. They hate it when you do that.

I'm trying to apply this patch now, but it conflicts badly with another patch
that camel cases a bunch of symbols in ShowAuthors, using replace. The problem
is that your patch also camel cases several symbols but manually.

I can resolve the conflicts by hand, but I'd really rather not. Is it ok if I
amend your patch not to have conflicts and apply that (or alternatively could
you resubmit it against latest darcs-unstable?)

2009/12/13 Ganesh Sittampalam <bugs@darcs.net>:
>
> Ganesh Sittampalam <ganesh@earth.li> added the comment:
>
> I'm trying to apply this patch now, but it conflicts badly with another patch
> that camel cases a bunch of symbols in ShowAuthors, using replace. The problem
> is that your patch also camel cases several symbols but manually.
>
> I can resolve the conflicts by hand, but I'd really rather not. Is it ok if I
> amend your patch not to have conflicts and apply that (or alternatively could
> you resubmit it against latest darcs-unstable?)
>

Sorry, for my late response. I am quite busy lately. I don't mind if
you amend my patch and I won't definitely get to darcs hacking before
Christmas, so this would be probably the best solution.

Thanks, have amended and pushed now.