Patch 967: replace C SHA256 bindings with external libraries - Darcs bug tracker

Title	replace C SHA256 bindings with external libraries
Superseder		Nosy List	ganesh
Related Issues
Status	accepted	Assigned To
Milestone

Created on 2012-11-04.18:55:06 by ganesh, last changed 2012-11-12.01:45:28 by owst.

Files
File name	Status	Uploaded	Type	Edit	Remove
patch-preview.txt		ganesh, 2012-11-04.18:55:05	text/x-darcs-patch
replace-c-sha256-bindings-with-external-libraries.dpatch		ganesh, 2012-11-04.18:55:05	application/x-darcs-patch
unnamed		ganesh, 2012-11-04.18:55:05

See mailing list archives for discussion on individual patches.

Messages
msg16288 (view)	Author: ganesh	Date: 2012-11-04.18:55:05
This gets rid of some custom FFI bindings/embedded C code, and also solves a problem with a symbol clash with the cryptohash library (I also fixed the problem on the 2.8 branch with a more local hack). 1 patch for repository darcs-unstable@darcs.net:screened: Fri Nov 2 07:02:34 GMT 2012 Ganesh Sittampalam <ganesh@earth.li> * replace C SHA256 bindings with external libraries Attachments patch-preview.txt replace-c-sha256-bindings-with-external-libraries.dpatch unnamed
msg16333 (view)	Author: owst	Date: 2012-11-11.12:00:58
Had a quick discussion with Ganesh regarding the similarity between the library implementation and our old implementation. Came to the conclusion that if things were different we'd immediately see hash failures everywhere, which we don't http://irclog.perlgeek.de/darcs/2012-11-11#i_6142710
msg16334 (view)	Author: owst	Date: 2012-11-11.12:01:19
This depends on the Hlint patches.

History
Date	User	Action	Args
2012-11-04 18:55:06	ganesh	create
2012-11-11 12:00:59	owst	set	status: needs-screening -> accepted messages: + msg16333
2012-11-11 12:01:19	owst	set	status: accepted -> accepted-pending-tests messages: + msg16334
2012-11-12 01:45:28	owst	set	status: accepted-pending-tests -> accepted