Patch 994 Rename a test (and 1 more)

Title Rename a test (and 1 more)
Superseder Nosy List ganesh, owst
Related Issues
Status accepted Assigned To ganesh

Created on 2012-12-21.13:48:18 by owst, last changed 2013-02-16.15:26:28 by gh.

File name Status Uploaded Type Edit Remove
patch-preview.txt owst, 2012-12-21.13:48:17 text/x-darcs-patch
rename-a-test.dpatch owst, 2012-12-21.13:48:18 application/x-darcs-patch
unnamed owst, 2012-12-21.13:48:18
See mailing list archives for discussion on individual patches.
msg16458 (view) Author: owst Date: 2012-12-21.13:48:18
The first patch renames a test to the issue it's testing. The second improves
the error message presented by darcs when invalid patterns are provided to
--match by changing a couple of calls of the Parsec <?> combinator.

2 patches for repository http://darcs.net:

Fri Dec 21 13:46:21 GMT 2012  Owen Stephens <darcs@owenstephens.co.uk>
  * Rename a test

Fri Dec 21 13:46:29 GMT 2012  Owen Stephens <darcs@owenstephens.co.uk>
  * Improve error message for bad match patterns
msg16504 (view) Author: ganesh Date: 2012-12-29.17:10:48
Great - the new error message is a definite improvement!

Some thoughts about future improvements that occurred to me while 

I found "expecting valid expressions over:" to be a bit obscure, 
although the pointer to "darcs help patterns" cleared it up quickly. 
Perhaps just "expecting one of:" would be good enough, and people can 
use "darcs help patterns" to find out about the boolean expressions.

It's a bit unfortunate that most of the keywords without any further 
arguments actually work and just match a lot of stuff, as it limits the 
ability of people to discover sensible arguments by experimentation and 
error messages.
msg16647 (view) Author: gh Date: 2013-02-16.15:26:28
Tests pass.
Date User Action Args
2012-12-21 13:48:18owstcreate
2012-12-21 13:48:57owstsetstatus: needs-screening -> needs-review
2012-12-29 17:10:49ganeshsetstatus: needs-review -> accepted-pending-tests
assignedto: ganesh
messages: + msg16504
nosy: + ganesh
2013-02-16 15:26:28ghsetstatus: accepted-pending-tests -> accepted
messages: + msg16647