darcs

Issue 1000 darcs tag should prompt for strange tag names

Title darcs tag should prompt for strange tag names
Priority wishlist Status resolved
Milestone Resolved in
Superseder Nosy List ckeen, darcs-devel, dmitry.kurochkin, ganesh, jaredj, kowey, thorkilnaur, tim
Assigned To ckeen
Topics ProbablyEasy, UI

Created on 2008-08-14.20:57:50 by tim, last changed 2009-08-27.14:18:39 by admin.

Messages
msg5522 (view) Author: tim Date: 2008-08-14.20:57:48
I typed "darcs tag ." unthinkingly, which tagged the repo with "." without
prompting me. Since no one is likely to want to create a tag called ".", perhaps
darcs could prompt "did you really mean to create a 1-character tag?" in this case?
msg5525 (view) Author: kowey Date: 2008-08-14.21:14:48
Congratulations, Tim!  You're our 1000th bug.

Is something like this really worth putting in the code, though?  You already
get feedback telling you it just created a TAG '.', which you could just obliterate.

Thoughts?
msg5526 (view) Author: tim Date: 2008-08-14.21:19:43
>>>Congratulations, Tim!  You're our 1000th bug.<<<

Yay! Do I get a cookie? :P

Anyway, I don't know how to obliterate a tag offhand. Of course I could go read
the manual and find out how. But that's just extra cognitive load which could
have been avoided if darcs had prompted me in the first place. Since creating a
tag called "." is almost always going to be a mistake, I think it's best to
write the code, which only has to be done once, but could potentially save time
and effort for more than one user.

I'm not passionate about this, but from an usability point of view, I think the
answer is clear.
msg5527 (view) Author: kowey Date: 2008-08-14.21:26:38
On Thu, Aug 14, 2008 at 21:19:48 -0000, Tim Chevalier wrote:
> Anyway, I don't know how to obliterate a tag offhand. Of course I could go read
> the manual and find out how. But that's just extra cognitive load which could
> have been avoided if darcs had prompted me in the first place. Since creating a
> tag called "." is almost always going to be a mistake, I think it's best to
> write the code, which only has to be done once, but could potentially save time
> and effort for more than one user.

Thanks.  Well, for what it's worth, tags are patches like any other, and
can be obliterated with darcs obliterate.

I wonder what we can do to make this more apparent.

Anyway, it's there as a ProbablyEasy bug for any new developers to try
fixing.  I'm not too enthused, but I can see your point :-)
msg5528 (view) Author: tim Date: 2008-08-14.21:29:01
I think even printing out a warning (without prompting) would be better than the
current behavior, though if you're adding code to warn, you might as well add
code to prompt.
msg5529 (view) Author: ganesh Date: 2008-08-14.22:36:41
IMO Warning is better than prompting as it's less likely to screw up scripts.
msg5532 (view) Author: tim Date: 2008-08-15.05:33:56
Martin DeMello suggested:
"what they oughta do is spit to stderr 'Did you really mean to tag this '.'? If
that was a mistake, paste the following line in at the prompt to undo it: ...'."
Which I like.
msg5533 (view) Author: kowey Date: 2008-08-15.06:57:12
Yeah, this is similar to the proposed solution for
http://bugs.darcs.net/issue395 -- do not ask for confirmation, but make it easy
for the user to undo.

Adding our swanky new need-volunteer tag (we know what to do, now somebody
please step up!)
msg6460 (view) Author: ckeen Date: 2008-10-25.23:01:55
The following patch updated the status of issue1000 to be resolved:

* resolve issue1000: warn when tags are too short (length name <2)
History
Date User Action Args
2008-08-14 20:57:50timcreate
2008-08-14 21:14:54koweysettopic: + ProbablyEasy, UI
nosy: + kowey, jaredj
status: unread -> unknown
messages: + msg5525
2008-08-14 21:19:48timsetnosy: beschmi, kowey, darcs-devel, dagit, tim, jaredj
messages: + msg5526
2008-08-14 21:26:40koweysetnosy: beschmi, kowey, darcs-devel, dagit, tim, jaredj
messages: + msg5527
2008-08-14 21:29:07timsetnosy: beschmi, kowey, darcs-devel, dagit, tim, jaredj
messages: + msg5528
2008-08-14 22:36:46ganeshsetnosy: + ganesh
messages: + msg5529
2008-08-15 05:34:01timsetnosy: beschmi, kowey, darcs-devel, dagit, ganesh, tim, jaredj
messages: + msg5532
2008-08-15 06:57:18koweysetstatus: unknown -> needs-reproduction
nosy: beschmi, kowey, darcs-devel, dagit, ganesh, tim, jaredj
messages: + msg5533
2008-08-15 15:16:21droundysetnosy: - darcs-devel
2008-10-25 10:14:11ckeensetstatus: needs-reproduction -> has-patch
nosy: + ckeen, dmitry.kurochkin, simon, thorkilnaur
assignedto: ckeen
2008-10-25 23:01:57ckeensetstatus: has-patch -> resolved-in-unstable
nosy: beschmi, kowey, dagit, ganesh, simon, tim, thorkilnaur, jaredj, dmitry.kurochkin, ckeen
messages: + msg6460
2009-04-22 03:32:06twbsetstatus: resolved-in-unstable -> resolved
nosy: beschmi, kowey, dagit, ganesh, simon, tim, thorkilnaur, jaredj, dmitry.kurochkin, ckeen
2009-08-06 21:11:02adminsetnosy: - beschmi
2009-08-10 23:42:07adminsetnosy: - dagit
2009-08-25 17:32:13adminsetnosy: + darcs-devel, - simon
2009-08-27 14:18:39adminsetnosy: kowey, darcs-devel, ganesh, tim, thorkilnaur, jaredj, dmitry.kurochkin, ckeen