darcs

Issue 1036 darcs ought to report connection failures as such, and not as repo not existing

Title darcs ought to report connection failures as such, and not as repo not existing
Priority bug Status given-up
Milestone Resolved in 2.8.0
Superseder Nosy List darcs-devel, dmitry.kurochkin, dmitry.tsygankov, kowey, simonpj, thorkilnaur, twb, zooko
Assigned To dmitry.tsygankov
Topics HTTP, SSH, UI

Created on 2008-08-26.07:47:05 by simonpj, last changed 2017-07-31.00:28:00 by gh.

Files
File name Uploaded Type Edit Remove
unnamed bsrkaditya, 2011-09-16.08:38:15 text/html
Messages
msg5699 (view) Author: simonpj Date: 2008-08-26.07:47:02
Darcs fails with a "Not a repository error", but succeeds if the same command is repeatd.

I'm afraid I accidentally used darcs 1.0.9 on this occasion rather than darcs 2 (it's much faster), so you may not be interested, but I'm in "report all darcs crashes" mode, so here you are.

On Windows.

Simon

bash-3.2$  darcs --version
1.0.9 (release)

bash-3.2$ ./darcs-all pull -av
        .......snip........
Getting and merging the following patches:
[Fix warnings in the unix package
Ian Lynagh <igloo@earth.li>**20080821120138]
[Fix the build when CONST_SIGPOLL == -1
Ian Lynagh <igloo@earth.li>**20080823160346
 We were defining, but not using, sigPOLL
]
[We now depend on concurrent (split off from base)
Ian Lynagh <igloo@earth.li>**20080824135158]
[add category field
Ross Paterson <ross@soi.city.ac.uk>**20080824003014]
diffing dir...
Applying patches to the local directories...
diffing dir...
Finished pulling and applying.
== running darcs pull -av --repodir libraries/Win32

darcs failed:  Not a repository: http://darcs.haskell.org/packages/Win32 (user error (Failed to download URL http://darcs.haskell.org/packages/Win32/_darcs/inventory : libcurl error code: 28))
darcs failed: 512 at ./darcs-all line 49.

bash-3.2$ ./darcs-all pull -av
        .......snip........
== running darcs pull -av --repodir libraries/unix
Pulling from "http://darcs.haskell.org/packages/unix"...
We have the following new (to them) patches:
They have the following patches to pull:
No remote changes to pull in!
== running darcs pull -av --repodir libraries/Win32
Pulling from "http://darcs.haskell.org/packages/Win32"...
We have the following new (to them) patches:
They have the following patches to pull:
No remote changes to pull in!
== libraries/HUnit repo not present; skipping
== libraries/QuickCheck repo not present; skipping
== libraries/haskell-src repo not present; skipping
== libraries/html repo not present; skipping
== libraries/mtl repo not present; skipping
msg5704 (view) Author: zooko Date: 2008-08-26.11:51:15
Thank you for the bug report, simonpj.  It seems to have to do with libcurl, so
I'm adding the "HTTP" tag, since Dmitri has been doing a lot of good work on
libcurl integration recently.
msg5705 (view) Author: kowey Date: 2008-08-26.13:24:51
If this helps anybody, an attempt at googling the curl error code 28 tells me
that it is a timeout.
msg5706 (view) Author: dmitry.kurochkin Date: 2008-08-26.13:34:20
Not sure what to do with this one.
- AFAIK there are no releases planned for 1.x branch.
- Curl code has been completely rewritten for darcs2.

So probably we should set status to "wont fix" or "resolved".

BTW whats is darcs-all? Some kind of windows specific script?

Regards,
  Dmitry
msg5707 (view) Author: kowey Date: 2008-08-26.13:40:58
I think I could agree with this.  Thanks for the bug reports, Simon!  But I
would personally rather report-all-crashes mode be transformed into
report-all-crashes-in-darcs-2 mode :-)

Dmitry: darcs-all is a GHC-repository-specific script that recursively calls
darcs on darcs repositories that have been fetched as subdirectories.  So
darcs-all pull will translate to calling darcs pull on all the sub-repositories
in the GHC repo.  There isn't an actual darcs notion of sub-repository yet, so
subdirectories (which happen to be darcs repositories) are used instead.
msg5708 (view) Author: zooko Date: 2008-08-26.13:44:53
I agree that this should be resolved as wontfix.

simonpj mentioned that the reason he is using darcs-1 is that it is faster than
darcs-2.  simonpj: does http://bugs.darcs.net/issue973 adequately describe your
problem with darcs-2 performance?

Hopefully issue973 will be fixed soon and then simonpk will be willing to
upgrade to darcs-2.
msg5711 (view) Author: simonpj Date: 2008-08-26.14:03:37
| simonpj mentioned that the reason he is using darcs-1 is that it is faster than
| darcs-2.  simonpj: does http://bugs.darcs.net/issue973 adequately describe your
| problem with darcs-2 performance?

I'm not sure.  I will report as I trip over new things

S
msg5712 (view) Author: simonpj Date: 2008-08-26.14:03:47
Fair enough.  But can you check that in darcs2, if the Internet connection fails or times out, then darcs does *not* say "repo doesn't exist" but instead says "Connection to xxx has been lost".

Simon

| -----Original Message-----
| From: dmitry.kurochkin [mailto:bugs@darcs.net]
| Sent: 26 August 2008 14:34
| To: dagit@codersbase.com; dmitry.kurochkin@gmail.com; eric.kow@gmail.com; Simon Peyton-Jones;
| zooko@zooko.com
| Subject: [issue1036] Intermittent failure, libcurl error code: 28 (1.0.9)
|
|
| dmitry.kurochkin <dmitry.kurochkin@gmail.com> added the comment:
|
| Not sure what to do with this one.
| - AFAIK there are no releases planned for 1.x branch.
| - Curl code has been completely rewritten for darcs2.
|
| So probably we should set status to "wont fix" or "resolved".
|
| BTW whats is darcs-all? Some kind of windows specific script?
|
| Regards,
|   Dmitry
|
| __________________________________
| Darcs bug tracker <bugs@darcs.net>
| <http://bugs.darcs.net/issue1036>
| __________________________________
msg5713 (view) Author: kowey Date: 2008-08-26.14:14:10
Retitling and re-opening.  Thanks for the suggestion!
msg13108 (view) Author: dmitry.tsygankov Date: 2010-11-19.06:00:09
Right now, in the unstable repository, the message is looking like this:

---
$ darcs get http://something.su

darcs failed:  Not a repository: http://something.su (CouldNotResolveHost)

Note: I was expecting to find a _darcs/inventory file because I could
not find (or read) _darcs/format and assumed that the remote repository
is old-fashioned.

$ darcs get http://123.123.123.123

darcs failed:  Not a repository: http://123.123.123.123
(CouldNotConnectToServer)

Note: I was expecting to find a _darcs/inventory file because I could
not find (or read) _darcs/format and assumed that the remote repository
is old-fashioned.

---
. The Note part is definitely out of place here. I think, it should be
easy to fix this bug now, as connection failures are already recognised
internally.
msg13204 (view) Author: kowey Date: 2010-11-22.11:22:54
If I understand correctly, this means the following message also applies 
to this ticket.

Dmitry, see patch470 about making the note less weird.

The following patch sent by Dmitry Tsygankov 
<dmitry.tsygankov@gmail.com> updated issue issue1637 with
status=resolved;resolvedin=2.8.0 HEAD

* resolve issue1637: report HTTP response code for HTTP errors 
Ignore-this: 67fcbd9a0d3466f21a3a045672a12218
msg13210 (view) Author: dmitry.tsygankov Date: 2010-11-22.12:04:48
> If I understand correctly, this means the following message 
> also applies to this ticket.

I wouldn't say so, unless somebody else fixed this. Issue1637 was about
reporting HTTP error code if the remote server said at least something,
this issue is about the case when we are disconnected from network, so
no HTTP error code here.

Even if patch470 removes the note, we still need to print something more
user-friendly here instead of
CouldNotResolveHost/CouldNotConnectToServer in CamelCase.
msg14728 (view) Author: ashmoran Date: 2011-09-12.17:26:52
This issue also arises with darcsden if you don't have an RSA key:

http://darcsden.com/alex/darcsden/issue/36
msg14730 (view) Author: bsrkaditya Date: 2011-09-16.08:38:15
Yeah this happened to me too, where I tried to push/get from a network that
does not allow ssh connections.

 The error message was:

"""darcs failed:  Not a repository:
bsrkaditya@patch-tag.com:/r/bsrkaditya/programming_contests
((scp) failed to fetch: bsrkaditya@patch-tag.com:
/r/bsrkaditya/programming_contests/_darcs/inventory)"""

I guess that darcs concluded that the repo does not exist when it could not
connect.(speculation)

On Mon, Sep 12, 2011 at 10:56 PM, Ash Moran <bugs@darcs.net> wrote:

>
> Ash Moran <ash.moran@patchspace.co.uk> added the comment:
>
> This issue also arises with darcsden if you don't have an RSA key:
>
> http://darcsden.com/alex/darcsden/issue/36
>
> __________________________________
> Darcs bug tracker <bugs@darcs.net>
> <http://bugs.darcs.net/issue1036>
> __________________________________
> _______________________________________________
> darcs-devel mailing list
> darcs-devel@darcs.net
> http://lists.osuosl.org/mailman/listinfo/darcs-devel
>



-- 
BSRK Aditya
Attachments
History
Date User Action Args
2008-08-26 07:47:05simonpjcreate
2008-08-26 11:51:18zookosetpriority: bug
nosy: + zooko
status: unread -> unknown
messages: + msg5704
2008-08-26 13:22:50koweysettopic: + HTTP
nosy: + dmitry.kurochkin
2008-08-26 13:24:53koweysetnosy: kowey, zooko, dagit, simonpj, dmitry.kurochkin
messages: + msg5705
title: Intermittent failure -> Intermittent failure, libcurl error code: 28 (1.0.9)
2008-08-26 13:34:23dmitry.kurochkinsetnosy: kowey, zooko, dagit, simonpj, dmitry.kurochkin
messages: + msg5706
2008-08-26 13:41:01koweysetstatus: unknown -> wont-fix
nosy: kowey, zooko, dagit, simonpj, dmitry.kurochkin
messages: + msg5707
2008-08-26 13:44:55zookosetnosy: kowey, zooko, dagit, simonpj, dmitry.kurochkin
messages: + msg5708
2008-08-26 14:03:39simonpjsetnosy: kowey, zooko, dagit, simonpj, dmitry.kurochkin
messages: + msg5711
2008-08-26 14:03:50simonpjsetnosy: kowey, zooko, dagit, simonpj, dmitry.kurochkin
messages: + msg5712
2008-08-26 14:14:12koweysetstatus: wont-fix -> unknown
nosy: kowey, zooko, dagit, simonpj, dmitry.kurochkin
messages: + msg5713
title: Intermittent failure, libcurl error code: 28 (1.0.9) -> darcs ought to report connection failures as such, and not as repo not existing
2009-08-10 23:43:56adminsetnosy: + simon, thorkilnaur, - dagit
2009-08-17 17:59:15koweysetpriority: bug -> feature
status: unknown -> needs-implementation
topic: + UI
nosy: kowey, zooko, simonpj, simon, thorkilnaur, dmitry.kurochkin
2009-08-17 17:59:25koweysetpriority: feature -> bug
nosy: kowey, zooko, simonpj, simon, thorkilnaur, dmitry.kurochkin
2009-08-25 18:14:35adminsetnosy: + darcs-devel, - simon
2009-08-27 14:25:45adminsetnosy: kowey, darcs-devel, zooko, simonpj, thorkilnaur, dmitry.kurochkin
2010-03-23 10:25:26koweylinkissue1385 superseder
2010-03-23 10:25:44koweysettopic: + SSH
nosy: + twb
2010-11-19 05:53:52dmitry.tsygankovsetassignedto: dmitry.tsygankov
nosy: + dmitry.tsygankov
2010-11-19 06:00:10dmitry.tsygankovsetmessages: + msg13108
2010-11-22 11:22:55koweysetstatus: needs-implementation -> resolved
messages: + msg13204
resolvedin: 2.8.0
2010-11-22 12:04:48dmitry.tsygankovsetstatus: resolved -> needs-implementation
messages: + msg13210
2011-09-12 17:26:53ashmoransetmessages: + msg14728
2011-09-16 08:38:16bsrkadityasetfiles: + unnamed
messages: + msg14730
2017-07-31 00:28:00ghsetstatus: needs-implementation -> given-up