pull fails to report "Can't pull from current repository" when the darcs repository pulled from is identified by a path 
that contains symbolic links. The problem seems to be in the code that tests this condition in 
src/Darcs/Commands/Pull.lhs:

>   here <- getCurrentDirectory
>   let repodirs = nub $ filter (/= here) $ map (fixUrl opts) unfixedrepodirs in do
>   -- Test to make sure we aren't trying to pull from the current repo
>   when (null repodirs) $
>         fail "Can't pull from current repository!"

Here, "here" is an absolute directory path, whereas "map (fixUrl opts) unfixedrepodirs" may contain directory paths with 
symbolic links. Hence, the fact that "here" really identifies the same directory as one of the paths in "map (fixUrl opts) 
unfixedrepodirs" may escape detection.

Best regards
Thorkil

Here is a patch that adds a test for this issue.

Best regards
Thorkil

Attachments

• test_for_issue_1057.dpatch.gz

I don't think I'd call this a bug.

David

Just to put a little perspective on this issue: I ran into this problem when I had placed a darcs darcs 
repository in a directory which I referred to using a directory path with a symbolic link in it. This caused the 
pull.sh test to fail: pull.sh contains the check (that I copied):
 
> #return special message when you try to pull from yourself
> DIR=`pwd`> not darcs pull --debug -a "$DIR" 2> out
> cat out
> grep 'Can.t pull from current repository' out

So, when $DIR contains symbolic links, this check causes pull.sh to fail.

This particular problem can be solved, at least on Mac OS X, by using

> DIR=`pwd -P`

which causes $DIR to become an absolute path with symbolic links resolved.

Best regards
Thorkil

The following patch updated the status of issue1057 to be resolved:

* resolve issue1057: this was fixed in the previous patch.