darcs

Issue 107 wish: obliterate a patch while pushing

Title wish: obliterate a patch while pushing
Priority wishlist Status wont-fix
Milestone Resolved in
Superseder wish: obliterate a patch while pushing
View: 107
Nosy List darcs-devel, dmitry.kurochkin, kowey, markstos, thorkilnaur, tommy, zooko
Assigned To
Topics UI

Created on 2006-01-25.18:21:32 by zooko, last changed 2010-01-28.15:34:16 by kowey.

Messages
msg415 (view) Author: zooko Date: 2006-01-25.18:21:31
I wish I could run "darcs push", and then when the interactive mode brings a
patch to my attention, I could obliterate that patch.  In a similar vein, 
I wish that I could run "darcs record", and then when the interactive mode
brings a hunk to my attention, I could revert that hunk.

Regards,

Zooko
msg2872 (view) Author: markstos Date: 2008-01-30.00:13:05
> I wish I could run "darcs push", and then when the interactive mode brings a
> patch to my attention, I could obliterate that patch.  

I vote against this as being unnecessary and uncommon (at least for me). 

> In a similar vein, I wish that I could run "darcs record", and then when the
> interactive mode brings a hunk to my attention, I could revert that hunk.

On the other hand, I have wanted to do this frequently and share this wish. 
In the interactive record menu, "r" (for revert) is conveniently unused. 

It probably merits an extra confirmation as a destructive action.
msg6950 (view) Author: zooko Date: 2008-12-31.17:29:44
MarkStos said this was uncommon (at least for him), but it is common for me.  It
just came up again.

I've done a few days worth of work, and now I want to split the work into
logically separate patches.  For example, the first patch will probably be the
test cases, separate from the changes to the code to make the code pass the new
tests.  So I run "darcs record" and start stepping through the files and hunks
looking for logically related changes that I can put into a single patch (see
also issue126).

Now I find a typo as one of the hunks.  I have to either cancel this "darcs
record" and go run "darcs revert" to destroy the typo, and then resume the
"darcs record" and reselect any hunks that I've already selected, or else I have
to remember that after I'm finished with this "darcs record" then I need to come
back and do a "darcs revert" and then step through the changes until I find this
typo again.

It would be perfect if there were a key I could press -- right now, while I'm in
the middle of a big interactive "darcs record" -- which would revert this typo.
msg6951 (view) Author: markstos Date: 2008-12-31.18:43:19
> Now I find a typo as one of the hunks.  I have to either cancel this "darcs
> record" and go run "darcs revert" to destroy the typo, and then resume the
> "darcs record" and reselect any hunks that I've already selected, or else I have
> to remember that after I'm finished with this "darcs record" then I need to come
> back and do a "darcs revert" and then step through the changes until I find this
> typo again.
> 
> It would be perfect if there were a key I could press -- right now, while I'm in
> the middle of a big interactive "darcs record" -- which would revert this typo.

I haven't re-read what I said before, but I do sometimes run into the same
case.  As I'm recording, I find that I've left some debugging output in the
code. It would be nice to revert the debugging statements while I'm looking at
them during the 'record'.

    Mark
msg8683 (view) Author: kowey Date: 2009-09-04.10:03:54
I think for reverting a hunk when recording, issue291 is good enough albeit not
quite the same.

While I see that is both useful and common, I think it's ultimately in
everybody's best interests if we applied the Keep-It-Simple-Stupid principle here.

We have to manage this delicate balance between being simple and featureful. 
Sometimes there is no trade-off and we can offer both at the same time.

I claim that this is one of those cases where a nice feature adds has an
unacceptable cost in simplicity (UI-wise).  OK, it's just another key-press to
offer, but all these tiny changes add up. Sorry Zooko, I'm going to resist this
change and recommend a wont-fix.  Discussion on darcs-users if you want to
re-open this.
msg9907 (view) Author: kowey Date: 2010-01-28.15:34:14
I intend to copy the discussion for revert-upon-record to issue1734
History
Date User Action Args
2006-01-25 18:21:32zookocreate
2006-01-31 13:20:48droundysetnosy: droundy, tommy, zooko
2008-01-30 00:13:06markstossetstatus: unread -> unknown
nosy: + markstos, kowey, beschmi
messages: + msg2872
2008-02-11 01:26:28markstossetstatus: unknown -> deferred
nosy: droundy, tommy, beschmi, kowey, markstos, zooko
title: I wish I could obliterate a patch while pushing, and revert a hunk while recording, ... -> wish: obliterate a patch while pushing, and revert a hunk while recording, ...
2008-12-31 17:29:49zookosetnosy: + dmitry.kurochkin, simon, thorkilnaur
messages: + msg6950
2008-12-31 18:43:23markstossetnosy: droundy, tommy, beschmi, kowey, markstos, zooko, simon, thorkilnaur, dmitry.kurochkin
messages: + msg6951
2009-08-06 17:43:01adminsetnosy: + jast, Serware, darcs-devel, dagit, mornfall, - droundy
2009-08-06 20:48:17adminsetnosy: - beschmi
2009-08-10 21:42:50adminsetnosy: - darcs-devel, jast, dagit, Serware, mornfall
2009-08-25 17:37:40adminsetnosy: + darcs-devel, - simon
2009-08-27 14:14:17adminsetnosy: tommy, kowey, markstos, darcs-devel, zooko, thorkilnaur, dmitry.kurochkin
2009-09-04 10:04:00koweysetstatus: deferred -> wont-fix
nosy: tommy, kowey, markstos, darcs-devel, zooko, thorkilnaur, dmitry.kurochkin
topic: + UI
messages: + msg8683
title: wish: obliterate a patch while pushing, and revert a hunk while recording, ... -> wish: obliterate a patch while pushing
2010-01-28 15:34:16koweylinkissue107 superseder
2010-01-28 15:34:16koweysetmessages: + msg9907
superseder: + wish: obliterate a patch while pushing