on my debian system, when running 'make test_unit', I get:

src/Darcs/Patch/QuickCheck.lhs:232:27: Not in scope: `quickCheck''
make: *** [src/Darcs/Patch/QuickCheck.o] Error 1

ghc-pkg shows I have quickCheck 2.1.0.1 installed:

/usr/lib/ghc-6.8.2/package.conf:
    Cabal-1.2.3.0, QuickCheck-1.1.0.0, QuickCheck-2.1.0.1, X11-1.4.2,

Hmmmm.  Is 2.1.0.1 a stable release? How did they change their API?

David

I'm not sure it is stable, I took the latest version available on  
hackage. I also looked at quickcheck 2.1, which does not seem to have  
quickcheck' (by skimming the source code). I didn't find a trace of a  
version of QuickCheck with the quickcheck' function (or of a 2.0  
version). What version are you getting success with?

Le 2 oct. 08 à 21:44, David Roundy a écrit :

>
>
> David Roundy <droundy@darcs.net> added the comment:
>
> Hmmmm.  Is 2.1.0.1 a stable release? How did they change their API?
>
> David
>
> ----------
> nosy: +droundy
> status: unread -> chatting
> topic:  -ProbablyEasy, Regression
>
> __________________________________
> Darcs bug tracker <bugs@darcs.net>
> <http://bugs.darcs.net/issue1119>
> __________________________________
>

On Thu, Oct 02, 2008 at 07:54:27PM -0000, Florent Becker wrote:
> I'm not sure it is stable, I took the latest version available on  
> hackage. I also looked at quickcheck 2.1, which does not seem to have  
> quickcheck' (by skimming the source code). I didn't find a trace of a  
> version of QuickCheck with the quickcheck' function (or of a 2.0  
> version). What version are you getting success with?

2.0 works fine.  QuickCheck is a particularly nasty package in this
regard.  Its developers don't seem to think that a stable API is
important.  I'd rather use quickcheck 1 for this reason, except that
quickcheck 2 has some darn-useful features for simplifying
test-cases.  I'm sorry to hear that quickcheck 2.1 breaks
compatibility again.  :(

David

here is a patch which makes quickCheck.lhs work with quickCheck 2.1. It still 
needs to be made conditionnal on which version of quickCheck is installed, 
using autoconf.

Attachments

• quickcheck-tests--for-quickcheck-2_1.dpatch

The patch I submitted does work, but the tests seem to take forever. It seems
quickCheck creates very big hunks, and the function delete_line does not like
this. However, quickCheck 2.0 seems to take forever on my machine too. Can
someone with a working quickCheck 2.0 try quickCheck 2.1, so that we can have a
point of comparison?
If there is no regression (or if we can fix it), it seems that quickcheck 2.1 is
the way to go, as it is the version which is on hackage, and the one that was
officially released.

I believe there is nothing more we need to do with this bug now that we're using
QC 2.1 by default and also now that Reinier has done all this work improving the
test suite.  Please re-open if I'm mistaken.