darcs

Issue 1128 bad temp filename in sendmail-command option

Title bad temp filename in sendmail-command option
Priority bug Status resolved
Milestone Resolved in
Superseder Nosy List bfr, darcs-devel, dmitry.kurochkin, kowey, thorkilnaur
Assigned To thorkilnaur
Topics

Created on 2008-10-06.22:17:34 by bfr, last changed 2009-10-23.23:46:12 by admin.

Files
File name Uploaded Type Edit Remove
send-mail1.sh bfr, 2008-10-06.22:17:32 application/x-shellscript
Messages
msg6252 (view) Author: bfr Date: 2008-10-06.22:17:32
'darcs send --sendmail-command <cmd>' is supposed to replace %a in <cmd> with 
the name of the temporary file which contains the patch bundle. Indeed it 
creates such a temporary file, but reports a wrong name. Thorkil Naur kindly 
provided the shell script send-mail1.sh to verify what arguments the 
sendmail-command really gets. See attached file. To reproduce, call

darcs 
send --sendmail-command='./send-mail1.sh %s %t %c %b %f %a %S %t %C %B %F %A 
something %<'

and look at send-mail1.sh.out.
Attachments
msg6253 (view) Author: kowey Date: 2008-10-06.23:33:06
Would it be possible to turn this into a regression test?
msg6281 (view) Author: thorkilnaur Date: 2008-10-08.20:34:49
Hello,

This is a simple test to see if I can make this message (that reports that a 
fix for issue1128 has been applied) appear in the bug tracker.

Best regards
Thorkil

On Tuesday 07 October 2008 20:20, David Roundy wrote:
> On Tue, Oct 07, 2008 at 06:36:50PM +0200, Ben Franksen wrote:
> > Tue Oct  7 13:53:03 CEST 2008  benjamin.franksen@bessy.de
> >   * resolve issue1128: must call execSendmail inside body of withOpenTemp
> > 
> > BTW: I have sent this with kmail (via a simple shell script). Yay!
> 
> Applied.  Thanks!
> 
> David
> _______________________________________________
> darcs-users mailing list
> darcs-users@darcs.net
> http://lists.osuosl.org/mailman/listinfo/darcs-users
>
msg6282 (view) Author: thorkilnaur Date: 2008-10-08.20:40:29
It also changed the title (there is an issue about this, I seem to remember), 
so for now, i'll just change it back.

Best regards
Thorkil
msg6283 (view) Author: thorkilnaur Date: 2008-10-08.20:51:21
I'm working on a test for this.

Best regards
Thorkil
msg6317 (view) Author: thorkilnaur Date: 2008-10-12.07:42:37
droundy has added send-external.sh that covers this, I have verified that it 
succeeds in the unstable repository, so I'll change the status accordingly.

Best regards Thorkil
History
Date User Action Args
2008-10-06 22:17:34bfrcreate
2008-10-06 23:33:07koweysetstatus: unread -> unknown
nosy: kowey, dagit, simon, thorkilnaur, dmitry.kurochkin, bfr
messages: + msg6253
2008-10-08 20:34:52thorkilnaursetnosy: kowey, dagit, simon, thorkilnaur, dmitry.kurochkin, bfr
messages: + msg6281
title: bad temp filename in sendmail-command option -> darcs patch: resolve issue1128: must call execSendmail inside body ...
2008-10-08 20:40:31thorkilnaursetnosy: kowey, dagit, simon, thorkilnaur, dmitry.kurochkin, bfr
messages: + msg6282
title: darcs patch: resolve issue1128: must call execSendmail inside body ... -> bad temp filename in sendmail-command option
2008-10-08 20:51:23thorkilnaursetstatus: unknown -> has-patch
nosy: kowey, dagit, simon, thorkilnaur, dmitry.kurochkin, bfr
messages: + msg6283
assignedto: thorkilnaur
2008-10-12 07:42:39thorkilnaursetstatus: has-patch -> resolved-in-unstable
nosy: kowey, dagit, simon, thorkilnaur, dmitry.kurochkin, bfr
messages: + msg6317
2009-04-22 03:36:32twbsetstatus: resolved-in-unstable -> resolved
nosy: kowey, dagit, simon, thorkilnaur, dmitry.kurochkin, bfr
2009-08-10 23:47:38adminsetnosy: - dagit
2009-08-25 17:30:23adminsetnosy: + darcs-devel, - simon
2009-08-27 14:19:29adminsetnosy: kowey, darcs-devel, thorkilnaur, dmitry.kurochkin, bfr
2009-10-23 22:35:15adminsetnosy: + benjamin.franksen, - bfr
2009-10-23 23:46:12adminsetnosy: + bfr, - benjamin.franksen