The diff command appears to be broken in 2.1.0.  I first noticed this when I
tried darcs diff -u --last=1 to get a unified diff of the last recorded patch
and it instead printed ALL the patches.  Here's a simpler example:
 mkdir a
 cd a
 darcs init
 touch a
 darcs add a
 darcs record -a -m "import"
 ls > a
 darcs whatsnew
 darcs diff
We see that the whatsnew clearly shows a change, while the diff is blank (at
least for me).

I can not reproduce this with darcs 2.1.0 (compiled from tarball from
darcs.net). But I see the bug in latest stable and unstable repos. I will send a
patch for it.

Also I do not see any issues with --last - it shows diff from "before last N
patches" to working dir. Can you provide more info on this?

Regards,
  Dmitry

Here's an example of the --last bug:
 darcs init
 touch a b
 darcs add a b
 darcs rec -a -m "add files"
 ls > a
 darcs rec -a -m "change a"
 wc a > b
 darcs rec -a -m "change b"
 darcs diff --last=1
For me, this shows "change b" at the top of the display, but then the patch that
it generates is actually the change to a.

Thanks! Now I see the problem. And it is fixed by the patch I have sent (and
attached).

But I do not see these problems in 2.1.0 tarball. Only in latest versions from
darcs repos. Can you give your 'darcs --version'?

Regards,
  Dmitry

Attachments

• resolve-issue1139_-fix-diff-when-no-arguments-given_.dpatch

I can't give a completely accurate darcs --version since I actually monkeyed
around with it by hand because ThisVersion.lhs was wrong.  It originally said
"2.1.0pre3 (+ 104 patches)", while --exact-version showed "[TAG 2.1.0
Eric Kow <E.Y.Kow@brighton.ac.uk>**20081009120532]" with 18 patches above it.  I
just went to my repo and did "darcs optimize --reorder" and darcs put 72 patches
above "tagged 2.1.0".  I'm not really sure what all's going on here...

The following patch updated the status of issue1139 to be resolved:

* resolve issue1139: make special cases handle no arguments gracefully. 
Ignore-this: 12b17a3940558860dd4caf7bb2619ec7
I accidentally broke this when refactoring Darcs.Match.  This change
restores some efficiency when no arguments are given and thus we are
creating copies of all the files in the repository.