I've attached the darcs1 repos that you can convert with darcs2 into the darcs2
format, and see the post-record test is no longer here (the file
_darcs/prefs/prefs is removed).

The test preference in  _darcs/prefs/prefs was well recorded by a patch that you
can see in the history of the repository.

It means the patches and pristine of the created repository are inconsistent.

Attachments

• htab.tar.gz

The darcs version is : 2.1.0 (+ 333 patches)

the patch gets created and copied but not applied.

Easier test case:
mkdir /tmp/test && cd /tmp/test
darcs init --old-fashioned-repo
darcs setpref–– test 'echo TESTED'
darcs record -a -m 'setpref'
darcs convert . ../test2

If you look into ../test2/_darcs/patches and zcat the only file you will see the patch.
Applying patches that are not located inside the working copy seems to be the problem.

I have still too little knowledge of darcs internals to point my finger at it though. Who wants to help?

[ckeen@hermes:/tmp/test3/_darcs/patches]$ zcat 0000000115-407e49678d2e10a2968e689205548a0a3d76f7f4112beec04c59a637735317fc
[setpref
foo@example.com**20081119202331
 Ignore-this: 3833165100f19d7dbbc1b177e962dfaf
] changepref test

We run onto this issue while converting our main repo and after everybody pulled 
a fresh copy of it. Since the repo seems to be in a not-as-consistent-as-one-
would-like state, we haven't pushed any new patches to it. However, we can't 
keep it on hold indefinitely.

So my question for the darcs developers is: what should we do now? Is it safe 
enough to push new patches? Is there some manual fixing we can run on the repo? 
Should we wait a little while?

Thanks!

David: may I ask you to comment?

One workaround I might suggest is to do a darcs changes -v and grep for setpref
test (in order to recreate the latest prefs file by hand).  I think that should
be a fairly safe operation, but I'd wait to see if David has any thoughts on the
matter.

If somebody could boil down Guillaume's example into a minimal test case for our
bugs/ directory, and submit a patch, it'd be great (and it would help us fix
things faster!)

On Fri, Nov 21, 2008 at 05:52:39PM -0000, Eric Kow wrote:
> David: may I ask you to comment?
> 
> One workaround I might suggest is to do a darcs changes -v and grep for setpref
> test (in order to recreate the latest prefs file by hand).  I think that should
> be a fairly safe operation, but I'd wait to see if David has any thoughts on the
> matter.

They can just copy the prefs file over from the old repository, or set
it to whatever you like.  And no, this has no consistency-related
issues, as _darcs/prefs/prefs isn't actually versioned.  It's stupid,
but that's the way it is (and yes, it's my fault).

It does sound like a bug in convert worth fixing.  It's pretty much
harmless, but definitely confusing.  And setpref is enough of a pain
as it is, without this extra trouble.

David

We still need a test case for this (pending dust settling on our testing
infrastructure).

http://wiki.darcs.net/RegressionTests

Dino, last time I checked, you were working on this bug (and hopefully
test case as well).  Is that correct?

Unfortunately I've been unable to test changes to the convert
functionality because of issue 1760: Very slow darcs convert with 2.4
(fine with 2.3.0)

On Wed, Apr 14, 2010 at 12:17:16 +0000, Dino Morelli wrote:
> Unfortunately I've been unable to test changes to the convert
> functionality because of issue 1760: Very slow darcs convert with 2.4
> (fine with 2.3.0)

Couldn't you use a toy repo?

We're also quite keen on having regression tests:
http://wiki.darcs.net/Development/RegressionTests

See also
http://wiki.darcs.net/Development/GettingStarted

-- 
Eric Kow <http://www.nltg.brighton.ac.uk/home/Eric.Kow>
PGP Key ID: 08AC04F9

I used the repo attached to this issue, HTab (131 patches), which I
thought was pretty small. I can try an extremely tiny one, yes.

The following patch updated the status of issue1232 to be resolved:

* Resolve issue1232: darcs convert forgets _darcs/prefs/prefs 
Ignore-this: 3973731c4c3c5297546570ebe3662f06

Added code to copy the _darcs/prefs/prefs file into the newly created
darcs2 repository during a convert. A dumb copy is possibly not the best
solution, but is better than nothing.

The following patch updated issue issue1232 with status=resolved;resolvedin=2.5.0 (current)

* Resolve issue1232: darcs convert forgets _darcs/prefs/prefs 
Ignore-this: 3973731c4c3c5297546570ebe3662f06

Added code to copy the _darcs/prefs/prefs file into the newly created
darcs2 repository during a convert. A dumb copy is possibly not the best
solution, but is better than nothing.

The following patch updated issue issue1232 with status=resolved;resolvedin=2.5.0 (current)

* Resolve issue1232: darcs convert forgets _darcs/prefs/prefs 
Ignore-this: 3973731c4c3c5297546570ebe3662f06

Added code to copy the _darcs/prefs/prefs file into the newly created
darcs2 repository during a convert. A dumb copy is possibly not the best
solution, but is better than nothing.