darcs

Issue 1248 darcs optimize --compress "loses" patches

Title darcs optimize --compress "loses" patches
Priority urgent Status resolved
Milestone 2.3.x Resolved in
Superseder Nosy List darcs-devel, dmitry.kurochkin, ganesh, kowey, mithrandi, thorkilnaur
Assigned To ganesh
Topics

Created on 2008-12-02.22:56:57 by mithrandi, last changed 2010-06-15.21:51:41 by admin.

Messages
msg6761 (view) Author: mithrandi Date: 2008-12-02.22:56:54
mithrandi@elvardein:~> darcs --version
2.1.0 (release)
mithrandi@elvardein:~/tmp> darcs get
http://slipgate.za.net/~mithrandi/darcs/Methanal/trunk methanal
Finished getting.
mithrandi@elvardein:~/tmp> cd methanal 
mithrandi@elvardein:~/tmp/methanal> darcs check --complete
The repository is consistent!
mithrandi@elvardein:~/tmp/methanal> darcs optimize --uncompress
Optimizing (un)compression of patches...
Optimizing (un)compression of inventories...
Done optimizing!
mithrandi@elvardein:~/tmp/methanal> darcs check --complete     
The repository is consistent!
mithrandi@elvardein:~/tmp/methanal> darcs optimize --compress  
Optimizing (un)compression of patches...
Optimizing (un)compression of inventories...
Done optimizing!
mithrandi@elvardein:~/tmp/methanal> darcs check --complete   
Unapplicable patch:
Mon Oct 29 15:39:54 SAST 2007  Jonathan Jacobs <jj@quotemaster.co.za>
  * Support inline labels for CheckboxInputs.
darcs: ./methanal/static/styles/methanal.css: openBinaryFile: does not exist (No
such file or directory)

The repository is publicly accessible, so this should be consistently
reproducible from anywhere with internet access.
msg6762 (view) Author: mithrandi Date: 2008-12-02.22:58:23
Forgot to mention that the check failure is due to several of the oldest patches
in the repository that seem to be missing; they don't show up in darcs changes
either.
msg6765 (view) Author: thorkilnaur Date: 2008-12-03.11:33:16
Thank you very much for reporting this. I hope that this problem has not caused you 
to lose data or too much time.

I am able to reproduce the problem exactly as you describe it using darcs 2.1.2 
(release). The check failure also happens if I leave out the darcs check --
uncompress:

> $ darcs get http://slipgate.za.net/~mithrandi/darcs/Methanal/trunk methanal
> Finished getting.
> $ cd methanal
> $ darcs check --complete
> The repository is consistent!
> $ darcs optimize --compress
> Optimizing (un)compression of patches...
> Optimizing (un)compression of inventories...
> Done optimizing!
> $ darcs check --complete
> Unapplicable patch:
> Mon Oct 29 14:39:54 CET 2007  Jonathan Jacobs <jj@quotemaster.co.za>
>   * Support inline labels for CheckboxInputs.
> darcs: ./methanal/static/styles/methanal.css: openBinaryFile: does not exist (No 
such file or directory)
>
> $

So it seems that what we need, initially at least, is for someone to boil this down 
to a test case of a more manageable size. Any volunteers for this task?

Thanks and best regards
Thorkil
msg7795 (view) Author: ganesh Date: 2009-05-11.21:04:24
I ran into this bug independently and constructed the following test case below.
I originally had a very similar error message to the original reported but after
boiling down it changed into

Looks like we have a difference...
Nothing

Inconsistent repository!

I strongly suspect that it's still the same underlying problem though. It seems
to be related to the line "Starting with tag:" disappearing from
_darcs/inventory at some point, though that's just a guess based on my
observations so far.

darcs init --old-fashioned
touch foo
darcs rec -a -m'foo' -l --author=me@me
darcs tag --author=me@me foo
darcs check
darcs optimize --reorder
darcs check
darcs optimize --compress
darcs check
msg7796 (view) Author: ganesh Date: 2009-05-11.21:40:03
I'm taking ownership of this for now as I intend to actively work on it, but
would very much appreciate input about the precise format of correct inventory
files, or to have someone more experienced with repo formats than me take this over.
msg7799 (view) Author: ganesh Date: 2009-05-12.20:13:29
OK, so it seems like current darcs doesn't support reading compressed
inventories, at least from non-hashed repos. Anyone know why this is?
msg7800 (view) Author: kowey Date: 2009-05-12.22:06:18
On Tue, May 12, 2009 at 20:13:32 -0000, Ganesh Sittampalam wrote:
> OK, so it seems like current darcs doesn't support reading compressed
> inventories, at least from non-hashed repos. Anyone know why this is?

If I may idly speculate: I'll bet this was just a simple oversight and
that we never expected that inventory files would be compressed.
msg8733 (view) Author: kowey Date: 2009-09-07.11:34:59
Hi Ganesh, Any news on this?  
In the meantime, I'm going to mark this as a release target for 2.4 :-)
msg8745 (view) Author: ganesh Date: 2009-09-07.19:41:57
Actually, it was fixed by this patch, but I messed up the formatting of 
the commit message by introducing an space between 'issue' and '1248'.

Tue May 12 21:54:29 BST 2009  Ganesh Sittampalam <ganesh@earth.li>
   * resolve issue 1248: support compressed inventories for darcs-1 repos
   This is important since optimize --compress can create them
msg8746 (view) Author: kowey Date: 2009-09-07.20:20:44
On Mon, Sep 07, 2009 at 20:41:16 +0100, Ganesh Sittampalam wrote:
> Actually, it was fixed by this patch, but I messed up the formatting of  
> the commit message by introducing an space between 'issue' and '1248'.
>
> Tue May 12 21:54:29 BST 2009  Ganesh Sittampalam <ganesh@earth.li>
>   * resolve issue 1248: support compressed inventories for darcs-1 repos
>   This is important since optimize --compress can create them

Oh! I should have thought to do darcs changes -p 1248.
Thanks!
History
Date User Action Args
2008-12-02 22:56:57mithrandicreate
2008-12-02 22:58:26mithrandisetstatus: unread -> unknown
nosy: kowey, dagit, simon, thorkilnaur, mithrandi, dmitry.kurochkin
messages: + msg6762
2008-12-03 11:33:20thorkilnaursetstatus: unknown -> needs-reproduction
nosy: kowey, dagit, simon, thorkilnaur, mithrandi, dmitry.kurochkin
messages: + msg6765
2009-05-11 21:04:29ganeshsetpriority: bug -> urgent
nosy: + ganesh
messages: + msg7795
2009-05-11 21:40:06ganeshsetnosy: kowey, dagit, ganesh, simon, thorkilnaur, mithrandi, dmitry.kurochkin
messages: + msg7796
assignedto: ganesh
2009-05-12 20:13:32ganeshsetnosy: kowey, dagit, ganesh, simon, thorkilnaur, mithrandi, dmitry.kurochkin
messages: + msg7799
2009-05-12 20:13:59ganeshsetstatus: needs-reproduction -> has-patch
nosy: kowey, dagit, ganesh, simon, thorkilnaur, mithrandi, dmitry.kurochkin
2009-05-12 22:06:22koweysetnosy: kowey, dagit, ganesh, simon, thorkilnaur, mithrandi, dmitry.kurochkin
messages: + msg7800
2009-08-10 23:52:33adminsetnosy: - dagit
2009-08-25 17:35:23adminsetnosy: + darcs-devel, - simon
2009-08-27 14:20:09adminsetnosy: kowey, darcs-devel, ganesh, thorkilnaur, mithrandi, dmitry.kurochkin
2009-09-07 11:35:04koweysettopic: + Target-2.4
nosy: kowey, darcs-devel, ganesh, thorkilnaur, mithrandi, dmitry.kurochkin
messages: + msg8733
2009-09-07 19:42:00ganeshsetnosy: + mithrandi1
messages: + msg8745
2009-09-07 19:43:54ganeshsetstatus: has-patch -> resolved
nosy: kowey, darcs-devel, ganesh, thorkilnaur, mithrandi, dmitry.kurochkin, mithrandi1
topic: + Target-2.3, - Target-2.4
2009-09-07 20:20:46koweysetnosy: kowey, darcs-devel, ganesh, thorkilnaur, mithrandi, dmitry.kurochkin, mithrandi1
messages: + msg8746
2009-10-23 22:39:30adminsetnosy: - mithrandi1
2010-06-15 21:51:41adminsetmilestone: 2.3.x
2010-06-15 21:51:41adminsettopic: - Target-2.3