Issue 1250: check for newlines in setpref values - Darcs bug tracker

Title	check for newlines in setpref values
Priority	bug	Status	resolved
Milestone		Resolved in	2.5.0
Superseder		Nosy List	darcs-devel, dmitry.kurochkin, galbolle, jaredj, kowey, thorkilnaur, tommy
Assigned To		Topics	ProbablyEasy

Created on 2008-12-03.21:12:34 by tommy, last changed 2010-06-15.22:14:14 by admin.

Messages
msg6766 (view)	Author: tommy	Date: 2008-12-03.21:12:28
darcs setpref boringfile 'foo\nbar' where \n means newline This inserts two lines in _darcs/prefs/prefs with bar on the second line, which could mess up the prefs file. I think it will be fine to simply refuse boringfiles with newlines in their names. This bug is likely not limited to the boringfile pref, so other prefs that take string values should be checked too.
msg10214 (view)	Author: galbolle	Date: 2010-03-15.11:00:50
The following patch updated the status of issue1250 to be resolved: * resolve issue1250: check for newlines in setpref values Ignore-this: ea1194357318edb8953e0387bfe5841d
msg11388 (view)	Author: galbolle	Date: 2010-06-13.17:08:29
The following patch updated the status of issue1250 to be resolved-in-stable: * resolve issue1250: check for newlines in setpref values Ignore-this: ea1194357318edb8953e0387bfe5841d

History
Date	User	Action	Args
2008-12-03 21:12:34	tommy	create
2009-04-09 14:06:32	kowey	set	status: unread -> needs-reproduction nosy: tommy, kowey, dagit, simon, thorkilnaur, jaredj, dmitry.kurochkin title: setpref boringfile can't handle newline -> check for newlines in setpref values
2009-08-10 17:39:33	kowey	set	status: needs-reproduction -> needs-implementation nosy: tommy, kowey, dagit, simon, thorkilnaur, jaredj, dmitry.kurochkin
2009-08-10 23:52:39	admin	set	nosy: - dagit
2009-08-25 17:35:28	admin	set	nosy: + darcs-devel, - simon
2009-08-27 14:22:02	admin	set	nosy: tommy, kowey, darcs-devel, thorkilnaur, jaredj, dmitry.kurochkin
2010-01-05 13:50:23	galbolle	set	nosy: + galbolle assignedto: galbolle
2010-01-19 15:21:22	galbolle	set	assignedto: galbolle ->
2010-03-15 11:00:55	galbolle	set	status: needs-implementation -> resolved messages: + msg10214
2010-06-13 17:08:30	galbolle	set	status: resolved -> resolved-in-stable messages: + msg11388
2010-06-15 22:14:14	admin	set	status: resolved-in-stable -> resolved
2010-06-15 22:14:14	admin	set	resolvedin: 2.5.0