Greetings,

This is to report an apparent bug in the behavior of the "predist"
preference; if the "predist" program exists with a non-zero status, it
is ignored by "darcs dist" and the dist continues on to generate the
dist tarball instead of exiting immediately.  This caused a serious
problem in a production environment and it seems to be an oversight.
Suggested fix is to exit immediately from dist -- if a hook exits
non-zero -- with the same exit status.

Thanks!

Platform: Ubuntu Linux 8.10

$ darcs --exact-version
darcs compiled on Sep 29 2008, at 21:58:25
# configured Sat Jul 26 14:09:28 CEST 2008
./configure /usr/local/share/config.site /usr/local/etc/config.site

Context:

[TAG debian: 2.0.2-2
me@mornfall.net**20080726120856]

Thank you for this report. It appears to be a bug that should be relatively easy 
to fix, so I would like some volunteer to look at it. Initially, a confirmation 
of this behavior, a test case perhaps, would be useful.

Thanks and best regards
Thorkil

Patches submitted.

Hi Ben,

> benmos <ben@moseley.name> added the comment:
> 
> Patches submitted.

Thanks!  But I haven't received this yet.  Does darcs send work for you
with other projects?  Is sendmail (or the equivalent) configured on your
machine?

Apologies for that. I /think/ 'darcs send' should be working ok - I'm on OS X 
10.5, started postfix manually (sudo postfix start), and it all seemed to work 
ok when I used "--to" to send the patch to myself.

What I guess I may have done wrong is to forget to specify a sensible "from" 
address - so possibly the patches fell prey to spam filters. I've resent using 
an explicit "--from" this time. If that still doesn't work, and we can't think 
of anything else to check, I'll mail them by hand.

On Mon, Mar 02, 2009 at 08:13:17 -0000, benmos wrote:
> What I guess I may have done wrong is to forget to specify a sensible "from" 
> address - so possibly the patches fell prey to spam filters. I've resent using 
> an explicit "--from" this time. If that still doesn't work, and we can't think 
> of anything else to check, I'll mail them by hand.

Hmm, still nothing!  I vaguely recall that the darcs-users lists is very
picky about who it accepts mail from.  I don't remember the exact
details, though...

On the Mac, I've taken to using 'send sendmail-command msmtp -t %<'

I've sent them manually now (forwarded them both to "darcs-users@darcs.net" and 
to you personally Eric just-in-case).

Just for the record, I'm attaching a file with the raw email contents which I 
generated when I did the darcs send to myself - the "from:" address seems to be 
ok, but maybe there's some other problem.

The console output of me doing the actual send (first to myself - as in the 
attachment - and then for real):

patrick-moseleys-macbook-pro:me-darcs ben$ darcs send --to ben@moseley.name --
from ben@moseley.name
Creating patch to "/Users/ben/darcsHacking/unstable"...
Sun Mar  1 11:07:05 GMT 2009  ben@moseley.name
 * Adding test for setpref predist bug 1269
Shall I send this patch? (1/2)  [ynWsfvplxdaqjk], or ? for help: y
Sun Mar  1 12:26:29 GMT 2009  ben@moseley.name
 * resolve issue1269: setpref predist - exitcode ignored bug
Shall I send this patch? (2/2)  [ynWvplxdaqjk], or ? for help: y
Successfully sent patch bundle to: ben@moseley.name.

patrick-moseleys-macbook-pro:me-darcs ben$ darcs send --from 
ben@moseley.nameCreating patch to "/Users/ben/darcsHacking/unstable"...
Patch bundle will be sent to: darcs-users@darcs.net
Sun Mar  1 11:07:05 GMT 2009  ben@moseley.name
 * Adding test for setpref predist bug 1269
Shall I send this patch? (1/2)  [ynWsfvplxdaqjk], or ? for help: y
Sun Mar  1 12:26:29 GMT 2009  ben@moseley.name
 * resolve issue1269: setpref predist - exitcode ignored bug
Shall I send this patch? (2/2)  [ynWvplxdaqjk], or ? for help: y
Successfully sent patch bundle to: darcs-users@darcs.net.
patrick-moseleys-macbook-pro:me-darcs ben$

Attachments

• raw-darcs-email.txt

The following patch updated the status of issue1269 to be resolved:

* resolve issue1269: setpref predist - exitcode ignored bug 
Ignore-this: 37c7f6e0061896c457cb7eeefb1d1937