Html and Parsec have newer versions, but the dependencies for darcs are listed as "html == 1.0.*" and "parsec == 2.1.*"

Attachments

• /home/jovdmeer/darcs/darcs-2.1.2.2/*cabal

Hi Joris,

On Fri, Jan 02, 2009 at 10:10:27 -0000, Joris Vandermeersch wrote:
> Html and Parsec have newer versions, but the dependencies for darcs
> are listed as "html == 1.0.*" and "parsec == 2.1.*"

Thanks for pointing that out!

We're leaving parsec at 2.1 for fear of accidentally changing the way
date parsing (in the Darcs.OldDate module) works, and subtly breaking
darcs for older patches.  The risk is likely very small, on the other
hand.  If people push me hard enough, I might resurrect one of David's
patches which allows building with parsec 3 (after the 2009-01-15
release!).

On the other hand, maybe it would be good to investigate the situation
with the html package

We can quickly get a negative result by loosening the dependency and attempting to
compile and test darcs.  If that doesn't work, code definitely has to be edited.

The process is basically:

	editor darcs.cabal	# loosen dependency
	cabal install 'html >1'	# ...or whatever
	cabal build
	cabal test		# runs the unit tests

Note to use "cabal test" rather than "make test", as make will not use the binary
built by cabal.

I just did that, two tests failed:

> Running binary.sh ...                            failed.
> Probable reason :binary=example_binary.png
> function checkbinary(){
> 	  cmp $binary ../temp1/$binary
> }
> rm -rf temp1 temp2
> mkdir temp1 temp2
> cd temp1
> darcs init
> cp ../$binary .
> cp: cannot stat `../example_binary.png': No such file or directory
> 
> ...
> 
> Running issue709_pending_look-for-adds.sh ...    failed.
> Probable reason :
> . lib
> issue709_pending_look-for-adds.sh: line 4: lib: No such file or directory

I'm not too familiar with the darcs code or the tests, but i presume those
aren't related to parsec or html :)

-joris

On 11/01/09 13:47 -0000, Trent Buck wrote:
> 
> Trent Buck <trentbuck@gmail.com> added the comment:
> 
> We can quickly get a negative result by loosening the dependency and attempting to
> compile and test darcs.  If that doesn't work, code definitely has to be edited.
> 
> The process is basically:
> 
> 	editor darcs.cabal	# loosen dependency
> 	cabal install 'html >1'	# ...or whatever
> 	cabal build
> 	cabal test		# runs the unit tests
> 
> Note to use "cabal test" rather than "make test", as make will not use the binary
> built by cabal.
> 
> ----------
> nosy: +twb
> status: chatting -> need-volunteer
> 
> __________________________________
> Darcs bug tracker <bugs@darcs.net>
> <http://bugs.darcs.net/issue1296>
> __________________________________

On Mon, Jan 12, 2009 at 08:46:16AM -0000, Joris Vandermeersch wrote:
> I just did that, two tests failed: [...]  I'm not too familiar with
> the darcs code or the tests, but i presume those aren't related to
> parsec or html :)

I agree with that analysis.  Would you care to submit a patch
loosening the dependency in the way you tested?

Html dependency now at: 1.0.*
Parsec dependency now at: parsec       >= 2.0 && < 3.1