It appears that "darcs record --delete-log" file will delete the the log file
whether the record was successful or not (ie: all tests passed). 

So, if you do this:

darcs record --logfile=foo.txt --delete-logfile

And then the tests don't pass, you've lost foo.txt. 

My expection that is that --delete-logfile would only delete the log file after
a successful "record".

Mark: do you think you could submit a test case for this?

Our current best practices live here:
http://wiki.darcs.net/index.html/RegressionTests

Thanks!

Here's the test I plan to submit. Looks like this will be very easy to fix.

darcs init      --repo R        # Create our test repos.
cd R
touch f g
touch log
darcs add f
darcs setpref test 'exit 0'
darcs record -am f --test --logfile log --delete-logfile
test ! -e log
darcs setpref test 'exit 1'
touch log
darcs record -am g --test --logfile log --delete-logfile
test -e log
cd ..

Resolved by

Thu Sep 17 10:03:20 CEST 2009  Kamil Dworakowski <kamil@dworakowski.name>
  * resolve issue1300: logfile deleted on unsucessful record

The following patch updated the status of issue1300 to be resolved:

* resolve issue1300: logfile deleted on unsucessful record 
Ignore-this: ead95914b26e0df6a79450a1d955abe3

Don't honour --delete-logfile when the record fails for any reason, a test
failure for instance.

I have changed the definition of get_log not to delete the logfile, but to
return it for deferred deletion. I capitalized on the fact that get_log
was already returning (Just temp_logfile) for deferred deletion.

get_log is an exported name, used in AmendRecord, Tag and Rollback. Some
of them ignore the logfile to delete, though none of them accept
--delete-logfile flag, and thus they don't need to change, nor are they
affected in any way.

Unintended side effect of the change: with --delete-logfile flag present, a
massage '"Logfile left in " ++ filepath' gets printed in case of the test
failure on record. This may actually be desirable so I did not bother to
change it.