darcs

Issue 1301 remove zsh completion scripts

Title remove zsh completion scripts
Priority wishlist Status resolved
Milestone Resolved in
Superseder Nosy List darcs-devel, dmitry.kurochkin, ertai, kowey, thorkilnaur, twb
Assigned To
Topics

Created on 2009-01-05.00:03:03 by twb, last changed 2009-10-24.00:05:01 by admin.

Files
File name Uploaded Type Edit Remove
_darcs.zsh ertai, 2009-01-05.08:48:10 application/octet-stream
Messages
msg6966 (view) Author: twb Date: 2009-01-05.00:02:58
twb> For example, the zsh completion code is (according to #zsh)
twb> obsolete, having been more actively maintained with the zsh
twb> repository (which is apparently the norm for zsh completion
twb> scripts, unlike bash).

kowey> Sounds like we should just remove it altogether then.

Confirm that I'm not crazy, then remove the zsh completion scripts.
msg6968 (view) Author: ertai Date: 2009-01-05.08:48:11
Excerpts from Trent Buck's message of Mon Jan 05 00:03:03 UTC 2009:
> 
> New submission from Trent Buck <trentbuck@gmail.com>:
> 
> twb> For example, the zsh completion code is (according to #zsh)
> twb> obsolete, having been more actively maintained with the zsh
> twb> repository (which is apparently the norm for zsh completion
> twb> scripts, unlike bash).
> 
> kowey> Sounds like we should just remove it altogether then.
> 
> Confirm that I'm not crazy, then remove the zsh completion scripts.

I do not agree, the completion script maintained by zsh does not even use
--list-options and --commands options, so commands and options are heavily
duplicated which leads to fragile and hard to maintain code.

However the situation of scripts in tools (zsh_completion_{new,old}) is not
perfect either, the zsh_completion_new one is close to the one maintained
by the Zsh group, so same issue there.

I would like to propose mine, that is a simple and short adaptation that
works fine one current Zsh's versions and use --commands and --list-options
to stay version agnostic.

All the best,
Attachments
msg6969 (view) Author: kowey Date: 2009-01-05.10:10:29
On Mon, Jan 05, 2009 at 08:48:14 -0000, Nicolas Pouillard wrote:
> I would like to propose mine, that is a simple and short adaptation that
> works fine one current Zsh's versions and use --commands and --list-options
> to stay version agnostic.

Care to submit this as a patch?  Thanks!
msg7435 (view) Author: thorkilnaur Date: 2009-03-12.10:20:38
Hello Nicolas,

--list-options
> > to stay version agnostic.
> 
> Care to submit this as a patch?  Thanks!
> 
> __________________________________
> Darcs bug tracker <bugs@darcs.net>
> <http://bugs.darcs.net/issue1301>
> __________________________________
> 

Any news here?

Thanks a lot and best regards
Thorkil
msg7517 (view) Author: twb Date: 2009-03-28.03:18:09
Nicholas,

This patch is now in the Darcs repo.  Does this mean the
zsh_completion_* files can be removed?

    Fri Mar 13 07:35:09 EST 2009  Nicolas Pouillard <nicolas.pouillard@gmail.com>
      * New updated Zsh completion script (c.f. issue 1301)
msg7520 (view) Author: ertai Date: 2009-03-28.10:42:37
I think they can be removed.
If someone prefer the old one please complain.
msg7541 (view) Author: twb Date: 2009-03-28.16:13:45
The following patch updated the status of issue1301 to be resolved:

* Resolve issue1301: remove obsolete zsh completion scripts. 
Ignore-this: d0a7415504f84eb7268417cf049a1492
History
Date User Action Args
2009-01-05 00:03:03twbcreate
2009-01-05 08:48:14ertaisetfiles: + _darcs.zsh
nosy: + darcs-devel, ertai
status: unread -> unknown
messages: + msg6968
2009-01-05 10:10:32koweysetnosy: kowey, darcs-devel, simon, twb, thorkilnaur, ertai, dmitry.kurochkin
messages: + msg6969
2009-03-12 10:20:41thorkilnaursetnosy: kowey, darcs-devel, simon, twb, thorkilnaur, ertai, dmitry.kurochkin
messages: + msg7435
2009-03-28 03:18:11twbsetnosy: kowey, darcs-devel, simon, twb, thorkilnaur, ertai, dmitry.kurochkin
messages: + msg7517
2009-03-28 10:42:39ertaisetnosy: kowey, darcs-devel, simon, twb, thorkilnaur, ertai, dmitry.kurochkin
messages: + msg7520
2009-03-28 16:13:48twbsetstatus: unknown -> resolved
nosy: kowey, darcs-devel, simon, twb, thorkilnaur, ertai, dmitry.kurochkin
messages: + msg7541
2009-04-22 02:38:33twbsetpriority: wishlist
nosy: kowey, darcs-devel, simon, twb, thorkilnaur, ertai, dmitry.kurochkin
2009-04-22 02:38:59twbsetnosy: kowey, darcs-devel, simon, twb, thorkilnaur, ertai, dmitry.kurochkin
2009-04-22 02:53:17twblinkissue1391 superseder
2009-08-25 17:37:57adminsetnosy: - simon
2009-08-27 14:17:37adminsetnosy: kowey, darcs-devel, twb, thorkilnaur, ertai, dmitry.kurochkin
2009-10-23 22:40:05adminsetnosy: + nicolas.pouillard, - ertai
2009-10-24 00:05:01adminsetnosy: + ertai, - nicolas.pouillard