darcs

Issue 1307 ./configure --disable-unit needs to make UNIT_FILES= # empty list

Title ./configure --disable-unit needs to make UNIT_FILES= # empty list
Priority critical Status resolved
Milestone Resolved in
Superseder Nosy List darcs-devel, dmitry.kurochkin, kowey, thorkilnaur, twb
Assigned To twb
Topics

Created on 2009-01-09.09:26:35 by twb, last changed 2009-08-27.14:14:38 by admin.

Messages
msg7024 (view) Author: twb Date: 2009-01-09.09:26:31
lelit> uhm, but it does not work: configure works, but one of the first recipes in the makefile tries to extract build deps:
lelit> src/Darcs/Patch/Test.hs:45:7:
lelit>     Could not find module `Test.QuickCheck':
lelit>       it is a member of package QuickCheck-1.1.0.0, which is hidden
lelit> make: *** [.depend] Error 1
[...]
twb> But make .depend should not need QuickCheck, that's definitely a bug.
twb> mornfall: this line is wrong:
twb> .depend:	autoconf.mk $(DARCS_FILES) $(UNIT_FILES)
lelit> the makefile should take care of not inspecting that file, when --disable-unit is given to configure
twb> mornfall: it needs to only include $UNIT_FILES *if* --disable-unit wasn't used
lelit> yeah
mornfall> twb: Have I screwed it up? I think I only resolved the conflict in favour of your version, when I was mucking with anything autoconfy.
lelit> compilation is going on now, thanks
twb> mornfall: it's my fault for introducing the dependency
twb> mornfall: but whoever added --disable-unit didn't finish the job
twb> mornfall: I'm looking at configure.ac and I don't see which variable is set by --disable-unit
twb> mornfall: it might be $(unit)
msg7025 (view) Author: twb Date: 2009-01-09.09:38:33
20:39 <twb> mornfall: OK, I will try to fix 1307 to-morrow.
20:39 <twb> mornfall: I think it's an important issue because GHC 6.6 users who don't use cabal (such as official Debian and Ubuntu packages) won't be able to build Darcs 2.2 otherwise.
msg7031 (view) Author: twb Date: 2009-01-10.10:16:28
The following patch updated the status of issue1307 to be resolved:

* Resolve issue1307: allow QuickCheck-less build. 

Due to the eager way dependency information is built, QuickCheck 2.1
was needed to during build even though the darcs binary doesn't use
it.  Because QuickCheck 2.1 is not available to Debian and Ubuntu
(without resorting to cabal), this would have meant that Darcs 2.2
could not be packaged for those platforms.

Because of .depend, the --disable-unit option added by Eric was just
meaning that the error happened during "make" instead of "configure".
This patch removes --disable-unit and makes QuickCheck always tested
for, but *not* finding QuickCheck is no longer an error.
History
Date User Action Args
2009-01-09 09:26:35twbcreate
2009-01-09 09:38:36twbsetstatus: unread -> unknown
assignedto: twb
messages: + msg7025
nosy: kowey, simon, twb, thorkilnaur, dmitry.kurochkin
2009-01-09 09:43:02twbsetpriority: critical
nosy: kowey, simon, twb, thorkilnaur, dmitry.kurochkin
2009-01-10 10:16:32twbsetstatus: unknown -> resolved
nosy: kowey, simon, twb, thorkilnaur, dmitry.kurochkin
messages: + msg7031
2009-08-25 17:38:28adminsetnosy: + darcs-devel, - simon
2009-08-27 14:14:38adminsetnosy: kowey, darcs-devel, twb, thorkilnaur, dmitry.kurochkin