Created on 2009-01-09.14:18:42 by galbolle, last changed 2010-03-15.11:00:47 by volothamp.
msg7027 (view) |
Author: galbolle |
Date: 2009-01-09.14:18:38 |
|
When using push to a repository that has patches which the local repo does not
have, we are creating a version of the repo that has never existed. This might
be dangerous. Push already warns in that situation, but too late, after the
patches have been pushed. I think it should warn before selecting the patches:
Remote repository has 42 unpulled patches, do you still want to push there?
|
msg7643 (view) |
Author: kowey |
Date: 2009-04-09.13:43:09 |
|
I could see this as being annoying (too many confirmation prompts!). It sounds
like the best thing to do is to submit a patch and wait for the ensuing
discussion on darcs-users.
|
msg7645 (view) |
Author: galbolle |
Date: 2009-04-09.13:52:36 |
|
It would not change the number of confirmation prompts, just the order. You want
confirmation prompts which do not depend on the selected patches before the
selection mechanism (less chance for wasted selection work!). I cannot see how
it would not be a net gain.
|
msg7647 (view) |
Author: galbolle |
Date: 2009-04-09.13:57:51 |
|
Just to make things clearer: we would not need one more confirmation prompt
(contrarily to what I wrote originally). Just warn at the beginning of
patch-selection, and let people use 'q' there.
So the interaction would be:
Patch 1/42:
Description
Do you want to push that patch (note: remote repository has 1664 unpulled
patches) ?
|
msg7648 (view) |
Author: kowey |
Date: 2009-04-09.14:00:40 |
|
Oh, I see what you mean. No objections here.
|
msg10213 (view) |
Author: volothamp |
Date: 2010-03-15.11:00:42 |
|
The following patch updated the status of issue1308 to be resolved:
* resolve issue1308 push should warn about unpulled patches *before* patch-selection
Ignore-this: 1f6fe64ad5cd84e7a8cae4261fcfa018
|
|
Date |
User |
Action |
Args |
2009-01-09 14:18:42 | galbolle | create | |
2009-04-09 13:43:14 | kowey | set | status: unread -> unknown nosy:
+ jaredj topic:
+ ProbablyEasy, UI messages:
+ msg7643 |
2009-04-09 13:52:42 | galbolle | set | nosy:
kowey, simon, thorkilnaur, jaredj, dmitry.kurochkin, galbolle messages:
+ msg7645 |
2009-04-09 13:53:09 | galbolle | set | nosy:
kowey, simon, thorkilnaur, jaredj, dmitry.kurochkin, galbolle title: push should warn about unpulled patches before patch-selection -> push should warn about unpulled patches *before* patch-selection |
2009-04-09 13:57:57 | galbolle | set | nosy:
kowey, simon, thorkilnaur, jaredj, dmitry.kurochkin, galbolle messages:
+ msg7647 |
2009-04-09 14:00:45 | kowey | set | status: unknown -> needs-reproduction nosy:
kowey, simon, thorkilnaur, jaredj, dmitry.kurochkin, galbolle messages:
+ msg7648 |
2009-08-25 17:38:32 | admin | set | nosy:
+ darcs-devel, - simon |
2009-08-27 14:16:41 | admin | set | nosy:
kowey, darcs-devel, thorkilnaur, jaredj, dmitry.kurochkin, galbolle |
2009-09-05 06:31:56 | kowey | set | status: needs-reproduction -> needs-implementation nosy:
kowey, darcs-devel, thorkilnaur, jaredj, dmitry.kurochkin, galbolle |
2010-03-15 11:00:47 | volothamp | set | status: needs-implementation -> resolved nosy:
+ volothamp messages:
+ msg10213 |
|