Created on 2009-01-11.17:20:43 by fx, last changed 2009-08-27.14:17:23 by admin.
msg7044 (view) |
Author: fx |
Date: 2009-01-11.17:20:39 |
|
A quick look at the source suggests that this must be a bug in the GHC
library but, if so, it seems worth recording and I can't see an existing
bug report. I found that matching failed in my own repo on a BST time
stamp, but not a GMT one. Here's an example in the darcs repo with a
recently-built binary:
$ ./darcs --version
2.2.0pre2 (+ 38 patches)
$ ghc --version
The Glorious Glasgow Haskell Compilation System, version 6.8.2
$ ./darcs diff --match 'date "Thu Oct 23 06:09:26 BST 2008"'
darcs failed: Couldn't match pattern "date "Thu Oct 23 06:09:26 BST 2008""
$ darcs diff --match 'date "Thu Oct 23 05:09:26 GMT 2008"'|head -2
Thu Oct 23 06:09:26 BST 2008 Trent W. Buck <trentbuck@gmail.com>
* Miscellaneous refactoring.
For what it's worth, it isn't a problem with glibc:
$ /lib64/libc.so.6 --version|head -1
GNU C Library development release version 2.8.90, by Roland McGrath et al.
$ date -d "Thu Oct 23 06:09:26 BST 2008"
Thu Oct 23 06:09:26 BST 2008
$ date -d "Thu Oct 23 05:09:26 GMT 2008"
Thu Oct 23 06:09:26 BST 2008
|
msg7046 (view) |
Author: kowey |
Date: 2009-01-11.21:34:20 |
|
On Sun, Jan 11, 2009 at 17:20:44 -0000, Dave Love wrote:
> A quick look at the source suggests that this must be a bug in the GHC
> library but, if so, it seems worth recording and I can't see an existing
> bug report. I found that matching failed in my own repo on a BST time
> stamp, but not a GMT one. Here's an example in the darcs repo with a
> recently-built binary:
Our support for timezone strings is fairly limited (it's a hard coded
list). I think a simple, pragmatic way to deal with this might be to
improve our documentation on this point, encourage people to use ISO
8601 dates for matching (I realise this means you can't just feed dates
darcs outputs back to darcs), and mark this as wont-fix
|
msg7066 (view) |
Author: fx |
Date: 2009-01-12.13:33:13 |
|
Eric Kow <bugs@darcs.net> writes:
> Our support for timezone strings is fairly limited (it's a hard coded
> list). I think a simple, pragmatic way to deal with this might be to
> improve our documentation on this point, encourage people to use ISO
> 8601 dates for matching (I realise this means you can't just feed dates
> darcs outputs back to darcs), and mark this as wont-fix
I'm not sure why I was misled that the relevant code wasn't in darcs.
Anyway, I think you can do something reasonable using the same set of
zones as GNU date(1) et al; I'll send a patch for the coverage and doc.
Also, I'll force UTC in the Emacs support where I initially found the
problem.
|
msg7104 (view) |
Author: fx |
Date: 2009-01-15.09:38:37 |
|
The following patch updated the status of issue1311 to be resolved:
* Resolve issue1311: Use time zones from GNU coreutils; improve doc.
Ignore-this: 883bc4ccdb1d27fde14ec9c76a4d2a45
|
msg7105 (view) |
Author: fx |
Date: 2009-01-15.09:57:39 |
|
The following patch updated the status of issue1311 to be resolved:
* Resolve issue1311: Use time zones from GNU coreutils; improve doc.
Ignore-this: 883bc4ccdb1d27fde14ec9c76a4d2a45
|
|
Date |
User |
Action |
Args |
2009-01-11 17:20:44 | fx | create | |
2009-01-11 21:34:24 | kowey | set | status: unread -> unknown nosy:
kowey, fx, simon, thorkilnaur, dmitry.kurochkin messages:
+ msg7046 |
2009-01-12 13:33:17 | fx | set | nosy:
kowey, fx, simon, thorkilnaur, dmitry.kurochkin messages:
+ msg7066 |
2009-01-15 09:38:39 | fx | set | status: unknown -> resolved nosy:
kowey, fx, simon, thorkilnaur, dmitry.kurochkin messages:
+ msg7104 |
2009-01-15 09:57:40 | fx | set | nosy:
kowey, fx, simon, thorkilnaur, dmitry.kurochkin messages:
+ msg7105 |
2009-04-22 02:41:03 | twb | set | priority: feature nosy:
kowey, fx, simon, thorkilnaur, dmitry.kurochkin |
2009-04-22 02:41:54 | twb | set | nosy:
kowey, fx, simon, thorkilnaur, dmitry.kurochkin title: date matching fails with BST timezone -> Improve timezone support |
2009-08-25 17:38:37 | admin | set | nosy:
+ darcs-devel, - simon |
2009-08-27 14:17:23 | admin | set | nosy:
kowey, fx, darcs-devel, thorkilnaur, dmitry.kurochkin |
|