darcs

Issue 1339 DARCS_DO_COLOR_LINES=True darcs rollback --edit injects ^

Title DARCS_DO_COLOR_LINES=True darcs rollback --edit injects ^
Priority bug Status resolved
Milestone Resolved in
Superseder Nosy List darcs-devel, dmitry.kurochkin, ertai, kowey, thorkilnaur, twb
Assigned To ertai
Topics

Created on 2009-02-02.01:25:46 by twb, last changed 2009-10-24.00:04:41 by admin.

Messages
msg7258 (view) Author: twb Date: 2009-02-02.01:25:43
As you can see from this transcript, ^[[00m nonsense is injected into
the rollback text.  Colouring should be suppressed in the default long
description when using rollback --edit.

    $ darcs init
    $ touch x
    $ darcs rec -lam x x
    Recording changes in "x":

    Finished recording patch 'x'
    $ DARCS_DO_COLOR_LINES=True VISUAL=true darcs rollback -a --edit
    Finished rolling back.
    $ darcs cha --last=1
    Mon Feb  2 12:25:29 EST 2009  Trent W. Buck <trentbuck@gmail.com>
      *

      rolling back:

      Mon Feb  2 12:24:57 EST 2009  Trent W. Buck <trentbuck@gmail.com>^[[00m
        * x^[[00m
      ^[[00m
          A ./x
    $
msg7626 (view) Author: kowey Date: 2009-04-09.11:43:40
Hi Nicolas,

I don't really know what's going on here.  Could you comment?  Is this just the
wrong printer being used somewhere?

Thanks!
msg7742 (view) Author: ertai Date: 2009-04-22.15:16:38
The following patch updated the status of issue1339 to be resolved:

* resolved issue1339: No longer use the color printer for the rollback log 
Ignore-this: db75c89b6b5ff745ebc4a818f9541e12
History
Date User Action Args
2009-02-02 01:25:46twbcreate
2009-04-09 11:43:42koweysetpriority: bug
nosy: + ertai
status: unread -> unknown
messages: + msg7626
assignedto: ertai
2009-04-15 17:34:01koweylinkissue1440 superseder
2009-04-15 17:34:39koweyunlinkissue1440 superseder
2009-04-22 15:16:41ertaisetstatus: unknown -> resolved
nosy: kowey, simon, twb, thorkilnaur, ertai, dmitry.kurochkin
messages: + msg7742
2009-08-25 17:40:18adminsetnosy: + darcs-devel, - simon
2009-08-27 14:19:51adminsetnosy: kowey, darcs-devel, twb, thorkilnaur, ertai, dmitry.kurochkin
2009-10-23 22:39:38adminsetassignedto: ertai -> nicolas.pouillard
nosy: + nicolas.pouillard
2009-10-23 22:40:14adminsetnosy: - ertai
2009-10-24 00:04:31adminsetassignedto: nicolas.pouillard -> ertai
nosy: + ertai
2009-10-24 00:04:41adminsetnosy: - nicolas.pouillard