darcs

Issue 1366 Never use libcurses directly (only the Haskell terminfo package)

Title Never use libcurses directly (only the Haskell terminfo package)
Priority feature Status resolved
Milestone Resolved in
Superseder Nosy List darcs-devel, dmitry.kurochkin, kowey, thorkilnaur, twb
Assigned To twb
Topics

Created on 2009-02-20.07:30:37 by twb, last changed 2009-08-27.14:17:29 by admin.

Messages
msg7345 (view) Author: twb Date: 2009-02-20.07:30:34
Judah Jacobson <judah.jacobson@gmail.com> writes:

> On Thu, Feb 19, 2009 at 8:55 PM, Trent W. Buck <trentbuck@gmail.com> wrote:
>> AFAIK we currently either use libncurses directly, or not at all.  I
>> see two Haskell third-party abstractions in cabal list: are either of
>> these viable and advisable to adopt?
>
> AFAICT, the only place where Darcs uses ncurses is to get the number
> of colors in the terminal.  And we already have an option to use the
> Haskell terminfo package for this (cabal install -f terminfo).  In
> fact, the "terminfo" package really depends on lib(n)curses anyway, so
> we should probably get rid of the FFI HAVE_CURSES (-f curses) case
> altogether.
>
> (Also, the terminfo package is used by Haskeline on POSIX, so it'll
> soon be a required dependency anway.)

Remove the option of using the libcurses package directly, i.e. forcing
everyone to use the Haskell terminfo package.
msg7444 (view) Author: twb Date: 2009-03-13.09:03:07
The following patch updated the status of issue1366 to be resolved:

* Resolve issue1366: remove unreachable code for direct ncurses use. 
Ignore-this: d63652e5d82ac9e5029c53ba25d1deac
The C ncurses library is only used directly if the Haskell Terminfo
library is not available.  As Haskeline is now mandatory, and
Haskeline depends on Terminfo, direct libncurses use is unreachable.
History
Date User Action Args
2009-02-20 07:30:37twbcreate
2009-02-20 07:46:21twbsetassignedto: twb
nosy: kowey, simon, twb, thorkilnaur, dmitry.kurochkin
2009-03-13 09:03:10twbsetstatus: unread -> resolved
nosy: kowey, simon, twb, thorkilnaur, dmitry.kurochkin
messages: + msg7444
2009-04-22 02:43:11twbsetpriority: feature
nosy: kowey, simon, twb, thorkilnaur, dmitry.kurochkin
2009-08-25 17:41:10adminsetnosy: + darcs-devel, - simon
2009-08-27 14:17:29adminsetnosy: kowey, darcs-devel, twb, thorkilnaur, dmitry.kurochkin