darcs

Issue 1446 darcs amend-record -m foo destroys long description without warning

Title darcs amend-record -m foo destroys long description without warning
Priority critical Status resolved
Milestone Resolved in
Superseder Nosy List darcs-devel, dmitry.kurochkin, greenrd, kowey, thorkilnaur, twb
Assigned To
Topics Confirmed

Created on 2009-04-21.07:24:48 by greenrd, last changed 2009-08-27.14:20:00 by admin.

Files
File name Uploaded Type Edit Remove
typescript twb, 2009-04-22.03:54:01 text/plain
Messages
msg7727 (view) Author: greenrd Date: 2009-04-21.07:24:46
darcs amend-record -m foo replaces the short description with foo, but deletes
any long description, without warning that it will do so. This was unexpected to me.
msg7733 (view) Author: twb Date: 2009-04-22.03:21:50
On Mon, Apr 20, 2009 at 09:24:46PM +0000, Robin Green wrote:
> darcs amend-record -m foo replaces the short description with foo,
> but deletes any long description, without warning that it will do
> so. This was unexpected to me.

Attached is a transcript demonstrating the problem.

I think that amend-record -m should only replace the patch name, and
leave the description alone.  Even if that is suboptimal, I think it
should be done promptly to avoid the data loss that currently occurs.
msg7735 (view) Author: twb Date: 2009-04-22.03:54:02
On Wed, Apr 22, 2009 at 03:21:54AM -0000, Trent Buck wrote:
> 
> Trent Buck <trentbuck@gmail.com> added the comment:
> 
> On Mon, Apr 20, 2009 at 09:24:46PM +0000, Robin Green wrote:
> > darcs amend-record -m foo replaces the short description with foo,
> > but deletes any long description, without warning that it will do
> > so. This was unexpected to me.
> 
> Attached is a transcript demonstrating the problem.
> 
> I think that amend-record -m should only replace the patch name, and
> leave the description alone.  Even if that is suboptimal, I think it
> should be done promptly to avoid the data loss that currently occurs.

Oops, I forgot to attach it.
Attachments
msg7757 (view) Author: dmitry.kurochkin Date: 2009-04-25.16:31:10
The following patch updated the status of issue1446 to be resolved:

* Resolve issue1446: make amend-record -m foo replace only the patch name. 
Ignore-this: c967b3bf806c77a6689af0cdf3b0ce70
History
Date User Action Args
2009-04-21 07:24:48greenrdcreate
2009-04-22 03:21:54twbsetstatus: unread -> unknown
nosy: + twb
messages: + msg7733
2009-04-22 03:22:51twbsettopic: + Confirmed
nosy: kowey, simon, twb, thorkilnaur, dmitry.kurochkin, greenrd
2009-04-22 03:54:04twbsetfiles: + typescript
nosy: kowey, simon, twb, thorkilnaur, dmitry.kurochkin, greenrd
messages: + msg7735
2009-04-22 03:55:06twbsetpriority: bug -> critical
nosy: kowey, simon, twb, thorkilnaur, dmitry.kurochkin, greenrd
2009-04-25 16:31:13dmitry.kurochkinsetstatus: unknown -> resolved
nosy: kowey, simon, twb, thorkilnaur, dmitry.kurochkin, greenrd
messages: + msg7757
2009-08-25 17:43:50adminsetnosy: + darcs-devel, - simon
2009-08-27 14:20:00adminsetnosy: kowey, darcs-devel, twb, thorkilnaur, dmitry.kurochkin, greenrd