>From src/formats.tex:

  These benefits, however, have not been fully realized in this
  release.

  [...] with a hashed repository, there is no need for darcs push to
  require a repository lock, so you could record patches while waiting
  for a push to finish (for instance, if it's waiting on the test
  suite).

Ensure that this is done.

I had a crack at this, but it isn't working.  To be honest, I'm not
even sure if I'm trying to defeat the right lock.  I'm dropping this
ticket for now; someone with better Haskell-fu can take it on.

[117 of 133] Compiling Darcs.Commands.Push ( src/Darcs/Commands/Push.lhs, dist/build/Darcs/Commands/Push.o )

src/Darcs/Commands/Push.lhs:108:124:
    Cannot match a monotype with `[DarcsFlag]
                                  -> (forall p. (Darcs.Patch.RepoPatch p) => Repository p -> IO a)
                                  -> IO a'
    Probable cause: `withRepository' is applied to too few arguments
    In the expression: withRepository
    In the second argument of `($)', namely
        `if format_has HashedInventory format then
             withRepository
         else
             withRepoReadLock'

Sat May 30 14:58:22 EST 2009  Trent W. Buck <trentbuck@gmail.com>
  * Resolve issue1469: push shouldn't lock hashed repos.

Attachments

• resolve-issue1469_-push-shouldn_t-lock-hashed-repos_.dpatch
• unnamed

Thanks for looking into this, Trent.  

I think we should bump this down in our priority list until we develop a much
stronger grasp of what the repository lock(s) are.  Basically, the current set
of darcs hackers needs to become more experienced in darcs (or somebody like
David needs to do this).

For example, we may still want locking just to avoid some sort of inventory file
race, or at least push the locks down to the bit that manipulates the inventory.

On the other hand, working like this could be a good way to get to know darcs
intimately, but I think there are less risky ways to go about that :-)

Currently push does not lock (hashed) repositories; I believe this is
since withRepoReadLock was made non-locking for hashed repositories.
Hence the issue is resolved.