darcs.net> darcs show contents --index=1 darcs.cabal

darcs: Maybe.fromJust: Nothing

The following change fixes the above bug but I am not sure if it doesn't break
something else, becasue I don't understand what have_nonrange_match is supposed
to be doing

darcs.net>darcs diff
Reading pristine 25 done, 495 queued.
diff -rN old-darcs.net/src/Darcs/Match.lhs new-darcs.net/src/Darcs/Match.lhs
116c116
< have_nonrange_match fs = isJust (has_index_range fs) || isJust
(nonrange_matcher fs::Maybe (Matcher Patch))
---
> have_nonrange_match fs = {-isJust (has_index_range fs) || -} isJust
(nonrange_matcher fs::Maybe (Matcher Patch))

so, that last comment was not a fix, I think it just ignores the index flag. not
sure what's needed for a fix, but attached is a test.

Attachments

• showContentsHeadIndexIssue1075.sh

Thanks Thomas.  Could you turn this into a standard regression test and send the
test as a patch?

http://wiki.darcs.net/Development/RegressionTests

Thanks!

Note that I intend to merge the users thomashartman1 tphyahoo and tphyahoo on
this tracker...

failing test attached.

Attachments

• failing-issue1705.sh

On Fri, Dec 11, 2009 at 21:49:58 +0000, Thomas Hartman wrote:
> failing test attached.

Thanks.  Please just darcs send it.

Patch name convention would make it something like

  "Accept issue1705: darcs show contents --index=1 file fails"

-- 
Eric Kow <http://www.nltg.brighton.ac.uk/home/Eric.Kow>
PGP Key ID: 08AC04F9

yep, attached.

On Fri, Dec 11, 2009 at 4:43 PM, Eric Kow <bugs@darcs.net> wrote:
>
> Eric Kow <kowey@darcs.net> added the comment:
>
> On Fri, Dec 11, 2009 at 21:49:58 +0000, Thomas Hartman wrote:
>> failing test attached.
>
> Thanks.  Please just darcs send it.
>
> Patch name convention would make it something like
>
>  "Accept issue1705: darcs show contents --index=1 file fails"
>
> --
> Eric Kow <http://www.nltg.brighton.ac.uk/home/Eric.Kow>
> PGP Key ID: 08AC04F9
>
> __________________________________
> Darcs bug tracker <bugs@darcs.net>
> <http://bugs.darcs.net/issue1705>
> __________________________________
>



-- 
Need somewhere to put your code? http://patch-tag.com
Want to build a webapp? http://happstack.com

Attachments

• failing-test-for-bug-1705.dpatch

On Sat, Dec 12, 2009 at 00:46:46 +0000, Thomas Hartman wrote:
> yep, attached.

Could you please send that to patches@darcs.net?

You don't need to attach it by hand; just use the darcs send command
and it will magically go to the right place.  Thanks!

-- 
Eric Kow <http://www.nltg.brighton.ac.uk/home/Eric.Kow>
PGP Key ID: 08AC04F9

The following patch sent by Eric Kow <kowey@darcs.net> updated issue issue1705 with
status=has-patch

* Resolve issue1705: show contents --index fixed by Owen. 
Ignore-this: 2a28f473146fe1d0d93db6baeda9c8ef

I'm guesssing this is the fix:
Wed Jun 29 12:57:16 BST 2011  Owen Stephens <darcs@owenstephens.co.uk>
  * Fix error with unhandled --index in show contents

The following patch sent by Eric Kow <kowey@darcs.net> updated issue issue1705 with
status=resolved;resolvedin=2.8.0 HEAD

* Resolve issue1705: show contents --index fixed by Owen. 
Ignore-this: 2a28f473146fe1d0d93db6baeda9c8ef

I'm guesssing this is the fix:
Wed Jun 29 12:57:16 BST 2011  Owen Stephens <darcs@owenstephens.co.uk>
  * Fix error with unhandled --index in show contents