Issue 1714: ALL mutex + foo no-mutex shouldn't reduce to foo mutex - Darcs bug tracker

Title	ALL mutex + foo no-mutex shouldn't reduce to foo mutex
Priority	bug	Status	resolved
Milestone		Resolved in	2.8.0
Superseder		Nosy List	darcs-devel, dmitry.kurochkin, kowey, twb
Assigned To		Topics

Created on 2009-12-09.06:31:04 by twb, last changed 2011-12-29.01:12:32 by noreply.

Files
File name	Uploaded	Type	Edit	Remove
accept-issuennnn_-all-mutex-_-foo-no_mutex-shouldn_t-reduce-to-foo-mutex_.dpatch	twb, 2009-12-09.06:31:01	text/x-darcs-patch
unnamed	twb, 2009-12-09.06:31:01	text/plain

Messages
msg9569 (view)	Author: twb	Date: 2009-12-09.06:31:01
Wed Dec 9 17:29:03 EST 2009 Trent W. Buck <trentbuck@gmail.com> * Accept issueNNNN: ALL mutex + foo no-mutex shouldn't reduce to foo mutex. Attachments accept-issuennnn_-all-mutex-_-foo-no_mutex-shouldn_t-reduce-to-foo-mutex_.dpatch unnamed
msg9578 (view)	Author: kowey	Date: 2009-12-09.16:22:57
Hi Trent, Was sending this to the bug tracker (and the strange patch name) intentional? Am I to interpret this as an implicit bug report?
msg9582 (view)	Author: twb	Date: 2009-12-10.02:29:33
Eric Kow wrote: > Was sending this to the bug tracker (and the strange patch name) > intentional? Am I to interpret this as an implicit bug report? It's a bug report. I wrote the test to confirm that the bug was present, and so I just sent the test AS the bug report. I'll simply move the script to failing-issue1714-... and amend-record to turn it into the patch "Accept issue1714:...".
msg14510 (view)	Author: galbolle	Date: 2011-06-09.20:05:14
I gather the bug is the following: in _darcs/prefs/defaults, if a flag is set once for ALL commands, and once for a given command, darcs combines the two values. 'run-prehook' and 'no-prehook' get combinated into 'run-prehook' regardless of which comes first, or which is associated with ALL/the command. The value given for one command should take precedence over the 'ALL' value, like et does when the flag has no --no-foo counterpart (for instance, the --prehook flag works as expected).
msg14797 (view)	Author: markstos	Date: 2011-10-28.02:15:40
This issue is supposed to be resolved by this patch: "resolve issue1714: make --no-{pre,post}hook and --{pre,post}hook interact sensibly"
msg14892 (view)	Author: noreply	Date: 2011-12-29.01:12:31
The following patch sent by Florent Becker <florent.becker@ens-lyon.org> updated issue issue1714 with status=resolved;resolvedin=2.8.0 HEAD * resolve issue1714: make --no-{pre,post}hook and --{pre,post}hook interact sensibly Ignore-this: 2b4453030077be0ef62b3e699853887d

History
Date	User	Action	Args
2009-12-09 06:31:04	twb	create
2009-12-09 16:22:59	kowey	set	status: unknown -> waiting-for title: darcs patch: Accept issueNNNN: ALL mutex + foo no-mutex shouldn't r... -> ALL mutex + foo no-mutex shouldn't reduce to foo mutex nosy: + kowey messages: + msg9578 priority: bug assignedto: twb
2009-12-10 02:29:36	twb	set	messages: + msg9582
2009-12-13 13:03:22	twb	set	assignedto: twb ->
2011-06-09 20:05:15	galbolle	set	messages: + msg14510
2011-10-28 02:15:41	markstos	set	status: waiting-for -> resolved messages: + msg14797 resolvedin: 2.8.0
2011-12-29 01:12:32	noreply	set	messages: + msg14892