darcs

Issue 1716 unit test failure: "Checking that there are no empty lines in email headers"

Title unit test failure: "Checking that there are no empty lines in email headers"
Priority bug Status resolved
Milestone 2.5.0 Resolved in 2.5.0
Superseder Nosy List darcs-devel, dmitry.kurochkin, ganesh, kowey, tux_rocker
Assigned To tux_rocker
Topics Devel

Created on 2009-12-13.17:12:41 by ganesh, last changed 2010-07-26.19:00:07 by tux_rocker.

Messages
msg9608 (view) Author: ganesh Date: 2009-12-13.17:12:37
With latest unstable, the unit tests have a failure with a single seed:

$ dist/build/unit/unit -t 'Checking that there are no empty lines in email
headers' --test-seed=1910310936
There are a total of 34 primitive patches.
There are a total of 384 patches.
"aaaaaaaaaaaaaaaaaaaaa"
"aa\ACKa\132aaa\DC4a\200aaaaaaaaaaa\153a "
Checking that there are no empty lines in email headers: [Failed]
Falsifiable with seed 1910310936, after 65 tests. Reason: Falsifiable

(build them by passing -ftest to cabal configure/cabal install).
msg9659 (view) Author: kowey Date: 2009-12-22.17:36:00
Reinier: would you be a good person to investigate this, or are things still 
tricky   on your end?  Thanks :-)
msg9660 (view) Author: ganesh Date: 2009-12-22.21:30:59
On Tue, 22 Dec 2009, Eric Kow wrote:

>
> Eric Kow <kowey@darcs.net> added the comment:
>
> Reinier: would you be a good person to investigate this, or are things still
> tricky   on your end?  Thanks :-)

FWIW, I don't think it's particularly urgent, I just thought I should 
record it. I suspect it's been around for ages, just not very likely to be 
hit by random testing.

Ganesh
msg9665 (view) Author: kowey Date: 2009-12-23.16:07:42
OK, I'll bump this to the next release on the grounds that we have enough work
on our hands.
msg11840 (view) Author: tux_rocker Date: 2010-07-23.12:48:06
The following patch updated issue issue1716 with status=resolved;resolvedin=2.6.0 HEAD

* resolve issue1716: allow mail header lines of all whitespace in test 
Ignore-this: 24a12e1cf2631b5363636cf32cf5e8da
  
Reading RFC822, it seems all-whitespace lines are allowed in the header section
when you've got trailing space that doesn't fit on the line before.
msg11883 (view) Author: tux_rocker Date: 2010-07-26.19:00:07
The following patch updated issue issue1716 with status=resolved;resolvedin=2.5.0 CURRENT

* resolve issue1716: allow mail header lines of all whitespace in test 
Ignore-this: 24a12e1cf2631b5363636cf32cf5e8da
  
Reading RFC822, it seems all-whitespace lines are allowed in the header section
when you've got trailing space that doesn't fit on the line before.
History
Date User Action Args
2009-12-13 17:12:41ganeshcreate
2009-12-15 08:52:54koweysettopic: + Target-2.4
2009-12-22 17:36:03koweysetstatus: unknown -> needs-reproduction
assignedto: tux_rocker
messages: + msg9659
nosy: + kowey, tux_rocker
2009-12-22 21:31:02ganeshsetmessages: + msg9660
2009-12-23 16:07:47koweysettopic: + Target-2.5, - Target-2.4
assignedto: tux_rocker -> (no value)
messages: + msg9665
2010-02-08 08:37:51koweysetpriority: bug
topic: + Devel
2010-06-14 06:49:22tux_rockersetassignedto: tux_rocker
2010-06-15 20:52:04adminsetmilestone: 2.5.0
2010-06-15 20:59:32adminsettopic: - Target-2.5
2010-07-23 12:48:07tux_rockersetstatus: needs-reproduction -> resolved
messages: + msg11840
resolvedin: 2.8.0
2010-07-26 19:00:07tux_rockersetmessages: + msg11883
resolvedin: 2.8.0 -> 2.5.0