darcs

Issue 1755 apparant line-break on "spontaneous branches" link in homepage

Title apparant line-break on "spontaneous branches" link in homepage
Priority bug Status resolved
Milestone Resolved in 2.4.x
Superseder Nosy List darcs-devel, dmitry.kurochkin, jaredj, kowey, wferi
Assigned To
Topics Community, ProbablyEasy

Created on 2010-03-01.14:06:48 by kowey, last changed 2010-06-16.14:39:12 by kowey.

Messages
msg10097 (view) Author: kowey Date: 2010-03-01.14:06:32
If you know your HTML/CSS here's a simple way to contribute to Darcs. 
We have an annoying cosmetic issue on our front page.  The link to
"spontaneous branches" appears to have a linebreak before it in many
browsers.

Using this bit of CSS:

DD {
  border: 1px solid red;
}

I discovered that the anchor tag and the text that follows it is being
treat as though it were outside the DD bounding box.  Is there some fact
about HTML/CSS standards that we're just missing?  Is there a simple
workaround (perhaps a lateral one that just re-designs the page altogether?)

Patches welcome! [Attention to detail matters; it shows you care].
msg10098 (view) Author: wferi Date: 2010-03-01.15:06:14
This discrepancy disappears if you remove "<a name="intro" />" before
the description list. Are you sure that the a tag can be empty? What's
that there for?
msg10099 (view) Author: kowey Date: 2010-03-01.15:42:36
On Mon, Mar 01, 2010 at 15:06:20 +0000, Wagner Ferenc wrote:
> This discrepancy disappears if you remove "<a name="intro" />" before
> the description list. Are you sure that the a tag can be empty? What's
> that there for?

Huh! Replacing that with <a name="intro"></a> solves the problem.
I'm pushing a patch now.

I don't get why this works, as it's supposed to be an XHTML document,
and we have plenty of self- closing tags.  Maybe you're right, that
anchors cannot contain Nothing, although they apparently can contain
Just ""...

Thanks!

-- 
Eric Kow <http://www.nltg.brighton.ac.uk/home/Eric.Kow>
PGP Key ID: 08AC04F9
msg10100 (view) Author: wferi Date: 2010-03-01.15:54:45
Probably http://www.w3.org/TR/xhtml1/#C_3 is relevant here.
Thanks for the fixes!
msg10189 (view) Author: kowey Date: 2010-03-14.20:26:56
The following patch updated the status of issue1755 to be resolved:

* Resolve issue1755: fix apparent hard line break in homepage. 
Ignore-this: 673fd7b5e9b2c023a7940464feb7d979

I'm not entirely clear on why this should work, as the document
is supposed to be XHTML.  Thanks to Wagner Ferenc for pointing
out the solution!
msg11383 (view) Author: kowey Date: 2010-06-13.17:02:16
The following patch updated the status of issue1755 to be resolved-in-stable:

* Resolve issue1755: fix apparent hard line break in homepage. 
Ignore-this: 673fd7b5e9b2c023a7940464feb7d979

I'm not entirely clear on why this should work, as the document
is supposed to be XHTML.  Thanks to Wagner Ferenc for pointing
out the solution!
History
Date User Action Args
2010-03-01 14:06:48koweycreate
2010-03-01 15:06:20wferisetmessages: + msg10098
2010-03-01 15:42:43koweysetmessages: + msg10099
2010-03-01 15:54:50wferisetmessages: + msg10100
2010-03-01 17:04:26wferisetstatus: needs-implementation -> resolved
2010-03-14 20:27:00koweysetmessages: + msg10189
2010-06-13 17:02:17koweysetstatus: resolved -> resolved-in-stable
messages: + msg11383
2010-06-15 22:14:21adminsetstatus: resolved-in-stable -> resolved
2010-06-15 22:14:21adminsetresolvedin: 2.5.0
2010-06-16 14:39:12koweysetresolvedin: 2.5.0 -> 2.4.x