darcs

Issue 1843 interactive 'v' prints double entries

Title interactive 'v' prints double entries
Priority bug Status resolved
Milestone Resolved in 2.5.0
Superseder Nosy List dmitry.kurochkin, galbolle, jaredj, kowey
Assigned To galbolle
Topics ProbablyEasy, Regression, UI

Created on 2010-05-12.13:32:34 by kowey, last changed 2010-06-15.22:39:15 by galbolle.

Messages
msg11051 (view) Author: kowey Date: 2010-05-12.13:32:31
Hitting 'v' in interactive mode prints things twice.  Is this introduced
by the recent SelectChanges work? (is it maybe one of the things that
patch242 fixes?)
msg11052 (view) Author: galbolle Date: 2010-05-12.13:35:29
I don't think it's fixed by patch242, i'll investigate.
msg11053 (view) Author: galbolle Date: 2010-05-12.14:01:03
This seems to only happen when viewing primitive patches (ie, in
record/revert/, can you confirm? If this is the case, it is because for
primary patches, the name of the patch is the same as its content.
Hence, v should either be a no-op for primary patches, or be disabled.
Is there a reason to keep it as a no-op?
msg11054 (view) Author: kowey Date: 2010-05-12.14:10:57
On Wed, May 12, 2010 at 14:01:04 +0000, Florent Becker wrote:
> This seems to only happen when viewing primitive patches (ie, in
> record/revert/, can you confirm?

Yep!

> If this is the case, it is because for primary patches, the name of
> the patch is the same as its content.  Hence, v should either be a
> no-op for primary patches, or be disabled.  Is there a reason to keep
> it as a no-op?

Hmm, I don't really know.  One use case off the top of mind mind
(I don't know if it's typical):

- user hits ^L to clear screen/mind
- user hits v

I forget what exactly triggered me to press 'v' (maybe a sort of absent
mindedness), but something in me wanted that 'v.

Note also that this affects 'p', but you probably already figured as
much.

For 'x', it does the funny thing of printing the summary and then the
patch content.


-- 
Eric Kow <http://www.nltg.brighton.ac.uk/home/Eric.Kow>
PGP Key ID: 08AC04F9
msg11195 (view) Author: galbolle Date: 2010-06-02.18:01:53
The following patch updated the status of issue1843 to be resolved:

* resolve issue1843:  interactive 'v' prints double entries   
Ignore-this: bdcec9798ec4b536bb628dad0c337949
msg11444 (view) Author: galbolle Date: 2010-06-15.22:39:14
The following patch updated issue issue1843 with status=resolved;resolvedin=2.5.0 (current)

* resolve issue1843:  interactive 'v' prints double entries   
Ignore-this: bdcec9798ec4b536bb628dad0c337949
History
Date User Action Args
2010-05-12 13:32:34koweycreate
2010-05-12 13:35:30galbollesetassignedto: galbolle
messages: + msg11052
2010-05-12 14:01:04galbollesetstatus: needs-implementation -> has-patch
messages: + msg11053
2010-05-12 14:10:58koweysetmessages: + msg11054
2010-06-02 18:01:54galbollesetstatus: has-patch -> resolved
messages: + msg11195
2010-06-15 22:39:15galbollesetmessages: + msg11444
resolvedin: 2.5.0