Hitting 'v' in interactive mode prints things twice.  Is this introduced
by the recent SelectChanges work? (is it maybe one of the things that
patch242 fixes?)

I don't think it's fixed by patch242, i'll investigate.

This seems to only happen when viewing primitive patches (ie, in
record/revert/, can you confirm? If this is the case, it is because for
primary patches, the name of the patch is the same as its content.
Hence, v should either be a no-op for primary patches, or be disabled.
Is there a reason to keep it as a no-op?

On Wed, May 12, 2010 at 14:01:04 +0000, Florent Becker wrote:
> This seems to only happen when viewing primitive patches (ie, in
> record/revert/, can you confirm?

Yep!

> If this is the case, it is because for primary patches, the name of
> the patch is the same as its content.  Hence, v should either be a
> no-op for primary patches, or be disabled.  Is there a reason to keep
> it as a no-op?

Hmm, I don't really know.  One use case off the top of mind mind
(I don't know if it's typical):

- user hits ^L to clear screen/mind
- user hits v

I forget what exactly triggered me to press 'v' (maybe a sort of absent
mindedness), but something in me wanted that 'v.

Note also that this affects 'p', but you probably already figured as
much.

For 'x', it does the funny thing of printing the summary and then the
patch content.


-- 
Eric Kow <http://www.nltg.brighton.ac.uk/home/Eric.Kow>
PGP Key ID: 08AC04F9

The following patch updated the status of issue1843 to be resolved:

* resolve issue1843:  interactive 'v' prints double entries   
Ignore-this: bdcec9798ec4b536bb628dad0c337949

The following patch updated issue issue1843 with status=resolved;resolvedin=2.5.0 (current)

* resolve issue1843:  interactive 'v' prints double entries   
Ignore-this: bdcec9798ec4b536bb628dad0c337949