darcs

Issue 1845 darcs refuses to record removed files

Title darcs refuses to record removed files
Priority bug Status resolved
Milestone 2.5.0 Resolved in 2.5.0
Superseder Nosy List dmitry.kurochkin, gh, kowey, mornfall
Assigned To mornfall
Topics FilePath, Regression, ThePendingPatch

Created on 2010-05-13.11:45:05 by gh, last changed 2010-07-01.21:22:03 by mornfall.

Messages
msg11061 (view) Author: gh Date: 2010-05-13.11:45:03
The last step in the following script fails with darcs HEAD and not
darcs 2.4.3 under Linux. It seems darcs HEAD wants that all file paths
are given as starting from the root of the working copy.

#!/bin/sh

set -v

mkdir -p tmp/subdir
cd tmp
touch a
touch subdir/b
darcs init
darcs add a subdir subdir/b
darcs rec -am"first add"
cd subdir
rm b
darcs rec b -am"delete b" # darcs failed:  None of the files you
specified exist!
# ~/bin/darcs-2.4.3* rec b -am"delete b"
# Recording changes in "subdir/b":
#
# Finished recording patch 'delete b'
msg11062 (view) Author: kowey Date: 2010-05-13.12:22:58
On Thu, May 13, 2010 at 11:45:05 +0000, gh wrote:
> The last step in the following script fails with darcs HEAD and not
> darcs 2.4.3 under Linux. It seems darcs HEAD wants that all file paths
> are given as starting from the root of the working copy.

Hmm, sounds like we've got a regression then.

Thanks for this!  See http://wiki.darcs.net/Development/RegressionTests
for the next step (filing a formal regression test; it's super easy now
that you've done all the hard stuff).

-- 
Eric Kow <http://www.nltg.brighton.ac.uk/home/Eric.Kow>
PGP Key ID: 08AC04F9
msg11063 (view) Author: gh Date: 2010-05-13.12:32:38
I should add that this does not happen for modified files. I can only
reproduce it with deleted files. (ie in the example, when b is modified,
darcs is not failing).
msg11069 (view) Author: kowey Date: 2010-05-13.15:52:37
Looks like this should be of interest to Petr.  Assigning for diagnosis.
msg11071 (view) Author: kowey Date: 2010-05-14.16:26:01
Perhaps another variant of this -- worth simplifying the test? -- is
adding a file and doing darcs record "."
msg11641 (view) Author: kowey Date: 2010-06-30.17:48:51
Just noting that my previous msg11071 seems to be a dupe of issue1871 and 
from the looks of it, not the same bug
msg11643 (view) Author: kowey Date: 2010-06-30.18:19:31
Also, the behaviour seems to have been mis-identified.
Can you confirm, Guillaume?

If you think if you have a case where it's actually about the location 
of the file wrt the working copy and not just the about pending patch, 
please open a new ticket and reference this one
msg11650 (view) Author: mornfall Date: 2010-06-30.18:44:18
The following patch updated issue issue1845 with status=resolved;resolvedin=2.6.0 HEAD

* Resolve issue1845: fix "darcs record f" for f a removed, version-tracked file. 
Ignore-this: 6c13d9e337c0f5df4321dd71640b9bc6
msg11665 (view) Author: mornfall Date: 2010-07-01.21:08:00
The following patch updated issue issue1845 with status=resolved;resolvedin=2.5.0 CURRENT

* Resolve issue1845: fix "darcs record f" for f a removed, version-tracked file. 
Ignore-this: 6c13d9e337c0f5df4321dd71640b9bc6
msg11674 (view) Author: mornfall Date: 2010-07-01.21:22:02
The following patch updated issue issue1845 with status=resolved;resolvedin=2.5.0 CURRENT

* Resolve issue1845: fix "darcs record f" for f a removed, version-tracked file. 
Ignore-this: 6c13d9e337c0f5df4321dd71640b9bc6
History
Date User Action Args
2010-05-13 11:45:05ghcreate
2010-05-13 12:22:59koweysetnosy: + kowey
messages: + msg11062
2010-05-13 12:23:55koweysetstatus: unknown -> needs-reproduction
topic: + Regression, Target-2.5, FilePath
2010-05-13 12:32:39ghsetmessages: + msg11063
2010-05-13 15:52:38koweysetassignedto: mornfall
messages: + msg11069
nosy: + mornfall
2010-05-14 16:26:02koweysetmessages: + msg11071
2010-06-15 20:52:15adminsetmilestone: 2.5.0
2010-06-15 21:00:04adminsettopic: - Target-2.5
2010-06-30 17:48:52koweysetmessages: + msg11641
2010-06-30 18:19:34koweysettopic: + ThePendingPatch
messages: + msg11643
title: darcs wants file paths from root of working copy -> darcs refuses to record removed files
2010-06-30 18:44:18mornfallsetstatus: needs-reproduction -> resolved
messages: + msg11650
resolvedin: 2.8.0
2010-07-01 21:08:01mornfallsetmessages: + msg11665
resolvedin: 2.8.0 -> 2.5.0
2010-07-01 21:22:03mornfallsetmessages: + msg11674