darcs

Issue 1875 --no-set-default flag doesn't work

Title --no-set-default flag doesn't work
Priority bug Status resolved
Milestone Resolved in 2.5.0
Superseder Nosy List abuiles, dmitry.kurochkin, jaredj, kowey
Assigned To
Topics ProbablyEasy

Created on 2010-06-10.22:33:11 by abuiles, last changed 2010-09-05.17:33:47 by tux_rocker.

Files
File name Uploaded Type Edit Remove
unnamed abuiles, 2010-06-10.22:33:10 text/html
Messages
msg11364 (view) Author: abuiles Date: 2010-06-10.22:33:10
If I create a local copy with --no-set-default I would expect no to find
_darcs/prefs/defaultrepo but It always appears there with the repository
from which  it was got.
A simple test case for it could be

. lib
darcs init --repo S
darcs get S Q --no-set-default
not find Q/_darcs/prefs/defaultrepo
Attachments
msg11366 (view) Author: kowey Date: 2010-06-11.10:02:01
On Thu, Jun 10, 2010 at 22:33:11 +0000, Adolfo Builes wrote:
> . lib
> darcs init --repo S
> darcs get S Q --no-set-default
> not find Q/_darcs/prefs/defaultrepo

Could you send that as a formal test case?
See http://wiki.darcs.net/Development/RegressionTests

Thanks,

-- 
Eric Kow <http://www.nltg.brighton.ac.uk/home/Eric.Kow>
PGP Key ID: 08AC04F9
msg11371 (view) Author: kowey Date: 2010-06-11.15:28:09
Actually, I need we first need to (action) determine if it even makes
sense in the first place for get to support the --set-default and
--no-set-default flag.

I'm going to submit a patch taking out the flag to get some comments.
msg11372 (view) Author: kowey Date: 2010-06-11.15:29:12
OK! That was quick...
Ian said on IRC: There are times I wouldn't want to have the default set
 When I'm making a totally separate branch, and wouldn't want to
accidentally push changes back or forth

so if you could submit that test, Adolfo, I think it'll be an easy fix
msg12217 (view) Author: kowey Date: 2010-08-17.16:52:11
The following patch updated issue issue1875 with status=resolved;resolvedin=2.5.0 CURRENT

* Resolve issue1875: avoid accidentally setting default. 
Ignore-this: d03cfc6111805515ae4f1ca467beab2c
Two cases fixed:
 - setting default on dry-run
 - setting default on darcs get --no-set-default
msg12262 (view) Author: kowey Date: 2010-08-22.16:22:47
The following patch updated issue issue1875 with status=resolved;resolvedin=2.8.0 HEAD

* Resolve issue1875: avoid accidentally setting default. 
Ignore-this: d03cfc6111805515ae4f1ca467beab2c
Two cases fixed:
 - setting default on dry-run
 - setting default on darcs get --no-set-default
History
Date User Action Args
2010-06-10 22:33:11abuilescreate
2010-06-11 10:02:02koweysetnosy: + kowey
messages: + msg11366
2010-06-11 15:28:10koweysetpriority: bug
status: unknown -> needs-reproduction
messages: + msg11371
2010-06-11 15:29:14koweysettopic: + ProbablyEasy
nosy: + jaredj
messages: + msg11372
2010-08-17 16:52:11koweysetstatus: needs-reproduction -> resolved
messages: + msg12217
resolvedin: 2.5.0
2010-08-22 16:22:48koweysetmessages: + msg12262
resolvedin: 2.5.0 -> 2.8.0
2010-09-05 17:33:47tux_rockersetresolvedin: 2.8.0 -> 2.5.0