Issue 1892: darcs unpull -o creates a busted bundle (reversed context) - Darcs bug tracker

Title	darcs unpull -o creates a busted bundle (reversed context)
Priority	bug	Status	resolved
Milestone	2.5.0	Resolved in	2.5.0
Superseder		Nosy List	dmitry.kurochkin, mornfall
Assigned To	mornfall	Topics

Created on 2010-07-15.01:54:33 by mornfall, last changed 2010-08-05.12:30:21 by mornfall.

Messages
msg11746 (view)	Author: mornfall	Date: 2010-07-15.01:54:32
I have managed to accidentally reverse the context order in makeBundle, which results in completely bogus bundles. The testsuite did not detect that. (I.e. instead of writing the context in RL order, I wrote it in FL order.) Witnesses do not apply here, either.
msg11749 (view)	Author: mornfall	Date: 2010-07-15.09:32:48
Gah. I just got confused, it was not makeBundle that was busted, but savetoBundle in Darcs.Commands.Unrecord. Nevertheless, the problem boils down to makeBundle taking a [PatchInfo] which can be easily reversed by mistake. I will submit a patch to fix this.
msg11968 (view)	Author: mornfall	Date: 2010-08-05.12:19:45
The following patch updated issue issue1892 with status=resolved;resolvedin=2.6.0 HEAD * Resolve issue1892: Improve safety of makeBundle* and fix a couple of related bugs. Ignore-this: 9eaa26edfdda09ac444f124130b9e74b
msg11972 (view)	Author: mornfall	Date: 2010-08-05.12:30:20
The following patch updated issue issue1892 with status=resolved;resolvedin=2.5.0 CURRENT * Resolve issue1892: Improve safety of makeBundle* and fix a couple of related bugs. Ignore-this: 9eaa26edfdda09ac444f124130b9e74b

History
Date	User	Action	Args
2010-07-15 01:54:33	mornfall	create
2010-07-15 09:32:48	mornfall	set	assignedto: mornfall messages: + msg11749 title: Testsuite does not cover bundle creation very well. -> darcs unpull -o creates a busted bundle (reversed context)
2010-07-25 14:31:42	tux_rocker	set	milestone: 2.5.0
2010-08-05 12:19:46	mornfall	set	status: needs-implementation -> resolved messages: + msg11968 resolvedin: 2.8.0
2010-08-05 12:30:21	mornfall	set	messages: + msg11972 resolvedin: 2.8.0 -> 2.5.0