darcs

Issue 1949 poor error output on 'darcs get ssh://'

Title poor error output on 'darcs get ssh://<host+path>'
Priority bug Status resolved
Milestone Resolved in
Superseder Nosy List creswick, dmitry.kurochkin
Assigned To
Topics SSH

Created on 2010-09-06.19:46:35 by creswick, last changed 2010-09-08.09:33:11 by kowey.

Messages
msg12490 (view) Author: creswick Date: 2010-09-06.19:46:34
When running darcs (2.4.4) get to clone a repo over ssh, using a
ssh:// style url, eg:

{{{
darcs get ssh://localhost/some/darcs/repo
}}}

darcs produces this output, and blocks indefinitely:

{{{
darcs: bug at src/URL.hs:246 compiled Sep  6 2010 12:00:56
Another possible bug in URL.waitNextUrl:  curl_multi_perform() - no
running handles
See http://wiki.darcs.net/BugTracker/Reporting for help on bug reporting.
}}}

re-writing the url to:

{{{
darcs get username@localhost:some/darcs/repo
}}}

works fine.

The output (and blocking behavior) is very misleading, particularly
given the use of ssh:// style urls with git.  If darcs won't support
that style of url (and hey, maybe there's a good reason not to) then
it should at least detect the presence of such a url early and exit.

I also believe that darcs should exit if it enters the 'bug report'
code that was triggered here.  This could cause some very difficult to
diagnose bugs in a non-interactive environment.
msg12491 (view) Author: mornfall Date: 2010-09-06.20:08:14
Rogan Creswick <bugs@darcs.net> writes:
> I also believe that darcs should exit if it enters the 'bug report'
> code that was triggered here.  This could cause some very difficult to
> diagnose bugs in a non-interactive environment.

It normally does, but I suspect the wrong thread died in this
case. Agreed that's a bug in itself...

Yours,
   Petr.
msg12494 (view) Author: kowey Date: 2010-09-07.10:25:20
Hi Rogan,

Could you let us know how the current darcs beta behaves? cabal update, 
cabal install darcs-beta if you've got the Haskell Platform.  Thanks!

I get "unsupported protocol" for what it's worth, which seems sane, but 
then again, I also get it for my darcs-2.4.3.

By the way, you could have a look at issue1575

BTS training: here we set to waiting-for instead of need-action because 
we feel we'd need Rogan's input, specifically and not just anybody 
working on the BTS (since we've already tried to reproduce it 
ourselves).  Note also that this ticket should be about the blocking and 
bad output, and not the lack of issue1575
msg12496 (view) Author: creswick Date: 2010-09-07.16:59:39
On Tue, Sep 7, 2010 at 3:25 AM, Eric Kow <bugs@darcs.net> wrote:
>
> Could you let us know how the current darcs beta behaves? cabal update,
> cabal install darcs-beta if you've got the Haskell Platform.  Thanks!
>

Ah, the beta does report unsupported protocol:

$  ./darcs get ssh://ssh.galois.com/darcs-repos/haskell-jvm-bridge/

darcs failed:  Not a repository:
ssh://ssh.galois.com/darcs-repos/haskell-jvm-bridge (Failed to
download URL ssh://ssh.galois.com/darcs-repos/haskell-jvm-bridge/_darcs/inventory:
Unsupported protocol)

That's definitely an improvement over the 2.4.4 behavior I'm seeing :).

(as an aside, I did eventually find issue 1575, but the search box on
the top-right is quite useless for that sort of thing)

--Rogan

> I get "unsupported protocol" for what it's worth, which seems sane, but
> then again, I also get it for my darcs-2.4.3.
>
> By the way, you could have a look at issue1575
>
> BTS training: here we set to waiting-for instead of need-action because
> we feel we'd need Rogan's input, specifically and not just anybody
> working on the BTS (since we've already tried to reproduce it
> ourselves).  Note also that this ticket should be about the blocking and
> bad output, and not the lack of issue1575
>
> ----------
> priority:  -> bug
> status: unknown -> waiting-for
> topic: +SSH
>
> __________________________________
> Darcs bug tracker <bugs@darcs.net>
> <http://bugs.darcs.net/issue1949>
> __________________________________
>
msg12504 (view) Author: kowey Date: 2010-09-08.09:33:10
Excellent, thanks.

PS: thanks also for the issue tracker commentary.  I've filed issue1952, 
taking the liberty of making you nosy on it.
History
Date User Action Args
2010-09-06 19:46:35creswickcreate
2010-09-06 20:08:14mornfallsetmessages: + msg12491
2010-09-07 10:25:21koweysetpriority: bug
status: unknown -> waiting-for
topic: + SSH
messages: + msg12494
2010-09-07 16:59:40creswicksetmessages: + msg12496
2010-09-08 09:33:11koweysetstatus: waiting-for -> resolved
messages: + msg12504