Issue 2260 darcs changes --last n doesn't take account of rebase patch

Title darcs changes --last n doesn't take account of rebase patch
Priority Status resolved
Milestone 2.10.0 Resolved in 2.10.0
Superseder Nosy List ganesh, owst
Assigned To ganesh
Topics Rebase

Created on 2012-10-20.23:03:48 by owst, last changed 2015-02-20.13:58:46 by noreply.

msg16255 (view) Author: owst Date: 2012-10-20.23:03:47
I did something like this:

    darcs init --repo R
    cd R
    touch m
    darcs rec -alm m
    touch n
    darcs rec -alm n
    echo yd | darcs rebase sus
    darcs cha --last 1

the final `cha` prints nothing, but `darcs cha --last 2` prints m's
details - I imagine it's not taking account of the rebase patch.
msg16346 (view) Author: ganesh Date: 2012-11-11.18:22:19
Thanks - I suspect a bunch of stuff needs to check for "internal" patches. 
It's a point against the "rebase as a patch" design.
msg18149 (view) Author: ganesh Date: 2015-02-18.06:14:21
I'm working on this at the moment. Just need to find all the places to 
ignore the rebase patch...
msg18188 (view) Author: noreply Date: 2015-02-20.13:58:44
The following patch sent by Ganesh Sittampalam <ganesh@earth.li> updated issue issue2260 with
status=resolved;resolvedin=2.10.0 HEAD

* resolve issue2260: skip internal patches when counting 
Ignore-this: 3ff465509d7e887ceb0b439c64fd1d47
Date User Action Args
2012-10-20 23:03:48owstcreate
2012-11-11 18:22:21ganeshsetstatus: unknown -> needs-implementation
topic: + Rebase
messages: + msg16346
milestone: 2.10.0
2015-02-18 01:52:54ghlinkissue2426 superseder
2015-02-18 06:14:22ganeshsetassignedto: ganesh
messages: + msg18149
nosy: + ganesh
2015-02-20 13:58:46noreplysetstatus: needs-implementation -> resolved
messages: + msg18188
resolvedin: 2.10.0