darcs

Issue 2327 grrr, couldn't get lock detection way too late!

Title grrr, couldn't get lock detection way too late!
Priority Status resolved
Milestone Resolved in 2.12.0
Superseder Nosy List alain91, jaredj, sleemanj
Assigned To alain91
Topics ProbablyEasy

Created on 2013-06-19.08:13:47 by sleemanj, last changed 2015-06-22.05:51:56 by noreply.

Files
File name Uploaded Type Edit Remove
unnamed sleemanj, 2013-06-19.08:13:46 text/html
Messages
msg16876 (view) Author: sleemanj Date: 2013-06-19.08:13:46
Darcs checks to see if it can lock WAY to late in the process when pushing.

    $ darcs push [path to remote]
    ...
    [ spend next few minutes choosing patches which I want to push ]
    ...
    Shall I push this patch? (121/121)  [ynW...], or ? for more options: y

    Waiting for lock [path to remote]/_darcs/lock
    Couldn't get lock [path to remote]/_darcs/lock
    darcs: fd:8: hPutBuf: resource vanished (Broken pipe)


Having the user spend time choosing patches carefully one by one and 
then instantly giving up as soon as it can't lock at the end of it 
(rather than saying "hey, I can't lock, try again?" or something) is 
rather poor design.
Attachments
msg18397 (view) Author: alain91 Date: 2015-05-07.21:40:33
see patch #1333
msg18476 (view) Author: bfrk Date: 2015-06-13.13:32:42
I added some comments to the proposed solution (patch1333).
msg18587 (view) Author: noreply Date: 2015-06-22.05:51:54
The following patch sent by Ben Franksen <benjamin.franksen@helmholtz-berlin.de> updated issue issue2327 with
status=resolved;resolvedin=2.12.0 HEAD

* resolve issue2327: ask user to keep trying if locking fails 
Ignore-this: a2e5649359fc677d2a193c7aa5a65d5c
History
Date User Action Args
2013-06-19 08:13:47sleemanjcreate
2014-03-17 01:41:44ghsettopic: + ProbablyEasy
nosy: + jaredj
2015-04-27 18:06:28alain91setfiles: + Lock.diff
messages: + msg18385
2015-04-27 21:25:07alain91setassignedto: alain91
nosy: + alain91
2015-05-07 21:36:41alain91setmessages: - msg18385
2015-05-07 21:40:16alain91setfiles: - Lock.diff
2015-05-07 21:40:34alain91setmessages: + msg18397
2015-05-08 19:53:04alain91setstatus: unknown -> has-patch
2015-06-13 13:32:43bfrksetmessages: + msg18476
2015-06-22 05:51:56noreplysetstatus: has-patch -> resolved
messages: + msg18587
resolvedin: 2.12.0