Issue 2414 log -h/--hash does not always work

Title log -h/--hash does not always work
Priority bug Status resolved
Milestone 2.10.0 Resolved in 2.10.0
Superseder Nosy List bf
Assigned To

Created on 2014-11-10.01:23:56 by bf, last changed 2014-12-15.18:44:20 by noreply.

msg17767 (view) Author: bf Date: 2014-11-10.01:23:54
1. Summarise the issue (what were doing, what went wrong?)

The new --hash HASHKEY option doesn't work in all cases. Here is a
simple one: In a recent the darcs repo:

ben@sarun[1]: .../darcs/screened > darcs log -p 'revert send default'
patch 52ca1f61c0ee059b77f3b0613d9ca607a2681e2e
Author: Guillaume Hoffmann <guillaumh@gmail.com>
Date:   Wed Nov  5 20:45:24 CET 2014
  * revert send default to --edit-description

Ok, copy and paste the hash and use -h:

ben@sarun[1]: .../darcs/screened > darcs log -h
patch f2ef0e0d387dfcd187ea46ab1f4b3e729433e281
Author: Ben Franksen <benjamin.franksen@helmholtz-berlin.de>
Date:   Sun Nov  9 23:27:31 CET 2014
  * added some empty lines and fixed a comment typo in Darcs.UI.RemoteApply

patch 6a17beecb4a66406758e65b15f31927fb7ed4c12
Author: Ben Franksen <benjamin.franksen@helmholtz-berlin.de>
Date:   Sun Nov  9 23:23:22 CET 2014
  * removed tests for flag membership in Darcs.UI.CommandsAux

.... and so on, until the pager has filled the screen.

2. What behaviour were you expecting instead?

That it shows me the one patch that matches the hash, i.e. the same as
darcs log -p 'revert send default'.

3. What darcs version are you using? (Try: darcs --exact-version)

2.9.9 (+ 165 patches)

4. What operating system are you running?

msg17913 (view) Author: noreply Date: 2014-12-15.18:44:19
The following patch sent by Guillaume Hoffmann <guillaumh@gmail.com> updated issue issue2414 with
status=resolved;resolvedin=2.10.0 HEAD

* resolve issue2414: use parseFlags instead of toMatchFlags where needed 
Ignore-this: cf0d8b7f5d939a0a9663a3eb51e4dc03
Date User Action Args
2014-11-10 01:23:56bfcreate
2014-12-15 18:44:20noreplysetstatus: needs-diagnosis/design -> resolved
messages: + msg17913
resolvedin: 2.10.0