darcs

Issue 2445 internal error if suspended patch is pulled into repository again

Title internal error if suspended patch is pulled into repository again
Priority Status needs-implementation
Milestone 2.12.0 Resolved in
Superseder Nosy List ganesh
Assigned To ganesh
Topics

Created on 2015-03-16.18:48:53 by ganesh, last changed 2015-09-18.13:28:06 by ganesh.

Files
File name Uploaded Type Edit Remove
draft_-resolve-issue2445_-update-the-patch-header-on-suspend-to-avoid-collisions.dpatch ganesh, 2015-09-18.13:28:05 application/octet-stream
Messages
msg18310 (view) Author: ganesh Date: 2015-03-16.18:48:51
If you pull a patch into a repository, "rebase suspend" it, then pull the same patch in again 
and try to "rebase unsuspend" it, you get an internal error caused by an 'impossible' in 
Darcs.Patch.Rebase.Viewing.forceCommuteName.

The simplest fix might be to rewrite the name of the patch as soon as it is suspended.
msg18730 (view) Author: ganesh Date: 2015-09-18.13:28:05
The "simplest fix" doesn't quite work - it breaks other tests that are 
trying to track dependencies properly. Need to think a bit harder about 
this, but I've attached the attempt anyway for my own or others' future 
reference. Note it conflicts with some of the current patches in 
screened.
Attachments
History
Date User Action Args
2015-03-16 18:48:53ganeshcreate
2015-03-20 22:27:40ghsetmilestone: 2.10.0
2015-04-18 17:39:09ghsetmilestone: 2.10.0 -> 2.12.0
2015-09-18 13:28:06ganeshsetfiles: + draft_-resolve-issue2445_-update-the-patch-header-on-suspend-to-avoid-collisions.dpatch
messages: + msg18730