darcs

Issue 2618 option --ask-deps adds too many dependencies

Title option --ask-deps adds too many dependencies
Priority Status unknown
Milestone Resolved in
Superseder Nosy List bf
Assigned To
Topics

Created on 2019-01-24.16:10:39 by bf, last changed 2019-01-24.18:42:20 by bf.

Messages
msg20639 (view) Author: bf Date: 2019-01-24.16:10:37
Seen with current screened. I haven't investigated this in depth yet. So
far it looks as if it erroneously adds all /implicit/ dependencies of
the selected patches, back to the latest clean tag.
msg20640 (view) Author: bf Date: 2019-01-24.16:16:03
Just confirmed that this happens with darcs-2.12.5, too.
msg20642 (view) Author: bf Date: 2019-01-24.17:30:16
Looking at the code of askAboutDepends this behavior isn't too
surprising. We call runSelection with FirstReversed and use the
resulting left ("first") segment directly as the result. Of course this
now includes all implicit dependencies of all selected patches.
msg20645 (view) Author: bf Date: 2019-01-24.18:42:19
For test script and fix see patch1795.
History
Date User Action Args
2019-01-24 16:10:39bfcreate
2019-01-24 16:16:05bfsetmessages: + msg20640
2019-01-24 17:30:17bfsetmessages: + msg20642
2019-01-24 18:42:20bfsetmessages: + msg20645