darcs

Patch 1795 accept issue2618: option --ask-deps adds too many depe...

Title accept issue2618: option --ask-deps adds too many depe...
Superseder Nosy List bf
Related Issues
Status needs-review Assigned To
Milestone

Created on 2019-01-24.16:38:44 by bf, last changed 2019-01-24.18:41:19 by bf.

Files
File name Status Uploaded Type Edit Remove
accept-issue2618_-option-__ask_deps-adds-too-many-dependencies.dpatch bf, 2019-01-24.18:39:19 application/x-darcs-patch
patch-preview.txt bf, 2019-01-24.18:39:19 text/x-darcs-patch
unnamed bf, 2019-01-24.18:39:19 text/plain
See mailing list archives for discussion on individual patches.
Messages
msg20641 (view) Author: bf Date: 2019-01-24.16:38:44
1 patch for repository http://darcs.net/screened:

patch 89dac3b4e27fcd8a161b3649da6a39dd152d5832
Author: Ben Franksen <ben.franksen@online.de>
Date:   Thu Jan 24 17:34:49 CET 2019
  * accept issue2618: option --ask-deps adds too many dependencies
Attachments
msg20643 (view) Author: bf Date: 2019-01-24.18:32:22
Now with a fix, too.

3 patches for repository http://darcs.net/screened:

patch 89dac3b4e27fcd8a161b3649da6a39dd152d5832
Author: Ben Franksen <ben.franksen@online.de>
Date:   Thu Jan 24 17:34:49 CET 2019
  * accept issue2618: option --ask-deps adds too many dependencies

patch bc4a10b1347bc072bcaa0635653e00a6dc456ac7
Author: Ben Franksen <ben.franksen@online.de>
Date:   Thu Jan 24 19:21:25 CET 2019
  * small improvement to test for issue2618

patch 1b950fc692074d8a2081925904bb8a48ed77ac18
Author: Ben Franksen <ben.franksen@online.de>
Date:   Thu Jan 24 19:21:59 CET 2019
  * resolve issue2618: option --ask-deps adds too many dependencies
  
  The trick is to filter out any patches in the result from runSelection that
  depend on later ones. While this may also filter out explicitly selected
  patches, these should rightfully not have been offered in the first place.
  I took the freedom to clean up and simplify the code for askAboutDepends.
  This concerns mainly the initial filtering of patches that are depended on
  by what we record, which is now reduced to a plain commuteWhatWeCanRL.
Attachments
msg20644 (view) Author: bf Date: 2019-01-24.18:39:19
Forgot to rename the test to indicate it is no longer failing; also rebased
the accept patch to squash with the improvement.

2 patches for repository http://darcs.net/screened:

patch fd8ec00c01bff2f09b5b1c3dabb22f09b2d04a5e
Author: Ben Franksen <ben.franksen@online.de>
Date:   Thu Jan 24 19:36:18 CET 2019
  * accept issue2618: option --ask-deps adds too many dependencies

patch e4a9cd9363e62946e78b5a602d1e373a0f27640d
Author: Ben Franksen <ben.franksen@online.de>
Date:   Thu Jan 24 19:36:55 CET 2019
  * resolve issue2618: option --ask-deps adds too many dependencies
  
  The trick is to filter out any patches in the result from runSelection that
  depend on later ones. While this may also filter out explicitly selected
  patches, these should rightfully not have been offered in the first place.
  I took the freedom to clean up and simplify the code for askAboutDepends.
  This concerns mainly the initial filtering of patches that are depended on
  by what we record, which is now reduced to a plain commuteWhatWeCanRL.
Attachments
History
Date User Action Args
2019-01-24 16:38:44bfcreate
2019-01-24 18:32:22bfsetfiles: + patch-preview.txt, accept-issue2618_-option-__ask_deps-adds-too-many-dependencies.dpatch, unnamed
messages: + msg20643
2019-01-24 18:39:19bfsetfiles: + patch-preview.txt, accept-issue2618_-option-__ask_deps-adds-too-many-dependencies.dpatch, unnamed
messages: + msg20644
2019-01-24 18:40:10bfsetfiles: - accept-issue2618_-option-__ask_deps-adds-too-many-dependencies.dpatch
2019-01-24 18:40:16bfsetfiles: - accept-issue2618_-option-__ask_deps-adds-too-many-dependencies.dpatch
2019-01-24 18:40:20bfsetfiles: - patch-preview.txt
2019-01-24 18:40:25bfsetfiles: - patch-preview.txt
2019-01-24 18:40:29bfsetfiles: - unnamed
2019-01-24 18:40:32bfsetfiles: - unnamed
2019-01-24 18:41:19bfsetstatus: needs-screening -> needs-review