I found that the test suite in the unstable branch complains at tabs
in the source.  It might be useful to have a HACKING (or something)
file with guidance on that sort of thing.

You could tell Emacs users to use

  (add-hook 'haskell-mode-hook '(lambda () (setq indent-tabs-mode nil)))

or use <URL:http://www.loveshack.ukfsn.org/emacs/dir-locals.el> or
<URL:http://www.loveshack.ukfsn.org/emacs/indent-tabs-maybe.el> to set
indent-tabs-mode locally.  It could actually be set in local variables
in the Haskell source files, and I guess something similar can be done
for anyone cursed with vi.

On Sat, Nov 04, 2006 at 17:22:38 +0000, Dave Love wrote:
> I found that the test suite in the unstable branch complains at tabs
> in the source.  It might be useful to have a HACKING (or something)
> file with guidance on that sort of thing.

Incidentally, have you seen the Developers' Tips page on the wiki?
http://darcs.net/DarcsWiki/DeveloperTips

We have a developer FAQ
http://darcs.net/DarcsWiki/DeveloperFAQ

And some developer Tips
http://darcs.net/DarcsWiki/DeveloperTips

You're right that we should probably say something about tabs, but on
the other hand with the test suite checking for it gets found right
away for most people :)

And also, discouraging tabs seems to be common in the Haskell
community so I think it's assumed for many darcs contributors.

If we added a HACKING file my proposal is have it point at the above
links and add something to the FAQ that shows how to disable tabs in
both Vim and Emacs.

Thoughts?
Jason

On 11/4/06, Dave Love <bugs@darcs.net> wrote:
>
> New submission from Dave Love <fx@gnu.org>:
>
> I found that the test suite in the unstable branch complains at tabs
> in the source.  It might be useful to have a HACKING (or something)
> file with guidance on that sort of thing.
>
> You could tell Emacs users to use
>
>   (add-hook 'haskell-mode-hook '(lambda () (setq indent-tabs-mode nil)))
>
> or use <URL:http://www.loveshack.ukfsn.org/emacs/dir-locals.el> or
> <URL:http://www.loveshack.ukfsn.org/emacs/indent-tabs-maybe.el> to set
> indent-tabs-mode locally.  It could actually be set in local variables
> in the Haskell source files, and I guess something similar can be done
> for anyone cursed with vi.
>
> ----------
> messages: 1169
> nosy: EricKow, droundy, fx, tommy
> status: unread
> title: guidance on hacking would be useful
>
> ____________________________________
> Darcs issue tracker <bugs@darcs.net>
> <http://bugs.darcs.net/issue330>
> ____________________________________
>
> _______________________________________________
> darcs-devel mailing list
> darcs-devel@darcs.net
> http://www.abridgegame.org/cgi-bin/mailman/listinfo/darcs-devel
>
>

Eric Kow <bugs@darcs.net> writes:

> Incidentally, have you seen the Developers' Tips page on the wiki?
> http://darcs.net/DarcsWiki/DeveloperTips

No; thanks.  It's probably worth at least pointing to that somewhere
in the source tree, though.

"Jason Dagit" <dagit@codersbase.com> writes:

> You're right that we should probably say something about tabs, but on
> the other hand with the test suite checking for it gets found right
> away for most people :)

The test suite takes an age on my system, though, which is a
disincentive to run it.

> And also, discouraging tabs seems to be common in the Haskell
> community so I think it's assumed for many darcs contributors.
>
> If we added a HACKING file my proposal is have it point at the above
> links and add something to the FAQ that shows how to disable tabs in
> both Vim and Emacs.

Actually, I just noticed that the current version of the Emacs Haskell
mode that monnier maintains sets indent-tabs-mode to nil anyhow, but I
happened to be using another.

On Sun, Nov 05, 2006 at 14:16:00 +0000, Dave Love wrote:
> The test suite takes an age on my system, though, which is a
> disincentive to run it.

Well, you can also run limited fragments of test suite.  Just put the
name of the tests you want to run in tests/test_to_run (newline
seperated)

In your case, you might have the entry haskell_policy.sh
which checks for tabs and what not

--eric (who is very slowly making his way through patches)

Part of the 1.0.9 README