darcs

Issue 493 make install does not completely respect --prefix

Title make install does not completely respect --prefix
Priority bug Status resolved
Milestone Resolved in
Superseder Nosy List darcs-devel, dmitry.kurochkin, fx, kowey, stephan, thorkilnaur, tommy
Assigned To
Topics

Created on 2007-07-03.13:59:03 by stephan, last changed 2009-08-27.14:11:56 by admin.

Messages
msg1793 (view) Author: stephan Date: 2007-07-03.13:59:02
Hi, darcs guys!

A short demo explains it best:

stephan@owl:/space/src/darcs$ ./configure --prefix=$HOME && make
...
stephan@owl:/space/src/darcs$ make install

test -d /home/stephan/bin || /usr/bin/install -c -d /home/stephan/bin
/usr/bin/install -c darcs /home/stephan/bin
:  -o /home/stephan/bin/darcs
test -d /home/stephan/etc/bash_completion.d || \
                /usr/bin/install -c -d /home/stephan/etc/bash_completion.d
/usr/bin/install -c -m 644 
tools/darcs_completion /home/stephan/etc/bash_completion.d/darcs
test -d /man/man1 || \
                /usr/bin/install -c -d /man/man1
/usr/bin/install: cannot create directory `/man': Permission denied
make: *** [installbin] Error 1

The bins appear to respect the install prefix, but man pages do not (and 
they try install under /man, which is wrong in any case).
msg1810 (view) Author: kowey Date: 2007-07-12.07:15:01
Hmm... I see this when I run ./configure:

    bindir          = ${exec_prefix}/bin
    sbindir         = ${exec_prefix}/sbin
    mandir          = ${prefix}/man
    datadir         = ${prefix}/share
    sysconfdir      = ${prefix}/etc
    libexecdir      = ${exec_prefix}/libexec

Note the difference between mandir and bindir.

I'm making Dave Love nosy on this bug as he seems to know his way around this
stuff.  Any comments, Dave?
msg1841 (view) Author: fx Date: 2007-07-16.13:55:45
Eric Kow <bugs@darcs.net> writes:

> Eric Kow <eric.kow@gmail.com> added the comment:
>
> Hmm... I see this when I run ./configure:
>
>     bindir          = ${exec_prefix}/bin
>     sbindir         = ${exec_prefix}/sbin
>     mandir          = ${prefix}/man
>     datadir         = ${prefix}/share
>     sysconfdir      = ${prefix}/etc
>     libexecdir      = ${exec_prefix}/libexec

First of all, what versions are we talking about?

> Note the difference between mandir and bindir.

They should be different, but not like that.  For the unstable and
stable branches, I see this at the end of configure's output:

  The build is configured as follows:

      bindir          = ${exec_prefix}/bin
      sbindir         = ${exec_prefix}/sbin
      mandir          = ${datarootdir}/man
      datadir         = ${datarootdir}
      sysconfdir      = ${prefix}/etc
      libexecdir      = ${exec_prefix}/libexec

However, I can see the error in the development versions.  It looks as
if I didn't test the change for adding datarootdir properly.  (It
makes a difference that the makefile fragment uses `:=', not `=' as in
portable makefiles, for assignments.)  Apologies.  I'll send a patch
anon.
msg1842 (view) Author: kowey Date: 2007-07-16.20:20:56
> >     mandir          = ${prefix}/man
> >     datadir         = ${prefix}/share
> 
> First of all, what versions are we talking about?

It was the unstable version.  Just to check, I have also done make
maintainer-clean.  Same thing... ah! yes, with autoconf 2.59 from the
default MacOS X.
msg1853 (view) Author: fx Date: 2007-07-17.09:29:49
"Eric Y. Kow" <eric.kow@gmail.com> writes:

> It was the unstable version.  Just to check, I have also done make
> maintainer-clean.  Same thing... ah! yes, with autoconf 2.59 from the
> default MacOS X.

Oh, right; I'd forgotten that difference.  Anyway, the patch I sent
should be OK regardless.
msg1907 (view) Author: kowey Date: 2007-07-23.07:46:29
This should be fixed in unstable now.  The relevant patch.  Thanks, Dave!

Sat Jul 14 18:54:41 CEST 2007  Dave Love <fx@gnu.org>
  * Define datarootdir early enough in autoconf.mk.in (issue 493).
History
Date User Action Args
2007-07-03 13:59:03stephancreate
2007-07-12 07:15:02koweysetstatus: unread -> unknown
nosy: + fx
messages: + msg1810
2007-07-16 13:55:48fxsetmessages: + msg1841
2007-07-16 20:20:57koweysetmessages: + msg1842
2007-07-17 09:29:52fxsetmessages: + msg1853
2007-07-23 07:46:30koweysetstatus: unknown -> resolved-in-unstable
messages: + msg1907
2007-07-31 18:00:16koweysetstatus: resolved-in-unstable -> resolved-in-stable
2008-09-16 21:31:12adminsetstatus: resolved-in-stable -> resolved
nosy: + dagit
2009-08-06 17:35:38adminsetnosy: + markstos, jast, Serware, dmitry.kurochkin, darcs-devel, zooko, mornfall, simon, thorkilnaur, - droundy, fx, stephan
2009-08-06 20:32:49adminsetnosy: - beschmi
2009-08-10 22:05:57adminsetnosy: + fx, stephan, - markstos, darcs-devel, zooko, jast, Serware, mornfall
2009-08-11 00:01:24adminsetnosy: - dagit
2009-08-25 17:49:50adminsetnosy: + darcs-devel, - simon
2009-08-27 14:11:56adminsetnosy: tommy, kowey, fx, darcs-devel, stephan, thorkilnaur, dmitry.kurochkin