darcs

Issue 496 delayed the check for --disabled until after reading defaults.

Title delayed the check for --disabled until after reading defaults.
Priority bug Status resolved
Milestone Resolved in
Superseder Nosy List darcs-bugs, darcs-devel, dmitry.kurochkin, kowey, markstos, thorkilnaur, tommy, trentbuck
Assigned To
Topics Confirmed, Darcs2, IncludesExampleOrTest, Patch

Created on 2007-07-09.17:25:10 by trentbuck, last changed 2009-08-27.14:07:02 by admin.

Files
File name Uploaded Type Edit Remove
add-functional-sh-test-for-issue496_.dpatch trentbuck, 2008-02-02.10:46:07 text/x-darcs-patch
unnamed trentbuck, 2008-02-02.10:46:07 text/plain
Messages
msg1797 (view) Author: twb Date: 2007-07-09.17:25:09
Observe the following listing:

| twb@baal[profile]$ darcs optimize
| 
| darcs failed:  Command optimize disabled by configuration!
| twb@baal[profile]$ cd ..
| twb@baal[canon]$ darcs optimize --repodir profile
| Done optimizing!
| twb@baal[canon]$

With --repodir, commands cannot be disabled or otherwise customized on
a per-repo basis.
-- 
Trent Buck
msg2882 (view) Author: markstos Date: 2008-01-30.02:10:32
Trent,

Thanks for the bug report. This sounds like a bug to me, too. I'm assigning it
to myself temporarily to create a formal test case for it.
msg3053 (view) Author: markstos Date: 2008-02-02.03:06:44
Trent,

I'm re-assigning this back to you in hopes that you'll submit your own test case
for it. The help would be appreciated! Otherwise, we'll get to it. 

See also:

tests/README.test_maintainers.txt

which provides an overview of the test suite setup. 

  Mark
msg3056 (view) Author: twb Date: 2008-02-02.10:46:07
Sat Feb  2 21:38:16 EST 2008  Trent W. Buck <twb@cyber.com.au>
  * Add functional sh test for issue496.

Sat Feb  2 21:38:48 EST 2008  Trent W. Buck <twb@cyber.com.au>
  * Don't use the builtin !; it has the wrong semantics.
Attachments
msg3059 (view) Author: markstos Date: 2008-02-02.16:34:07
Trent's test has been peer reviewed now, and moved to ./bugs, since it is failing. 

Thanks for the help, Trent!
msg3456 (view) Author: droundy Date: 2008-02-15.20:27:33
The following patch updated the status of issue496 to be resolved in the unstable branch:

* resolved issue496 delayed the check for --disabled until after reading defaults. 
As it turns out, this bug was specific to the --disabled flag, which was
treated specially (and buggily, as it turns out).  It was easily fixed by
moving the check for Disabled *after* we've confirmed the validity of the
repository and added any default flags.

You can view the patch details online here: 
http://darcs.net/cgi-bin/darcs.cgi/unstable/?c=annotate&p=20080215154653-72aca-f5db321bbf0a8e863d52b78fd11941c939e3507c.gz
History
Date User Action Args
2007-07-09 17:25:11trentbuckcreate
2008-01-30 02:10:33markstossetstatus: unread -> unknown
nosy: + markstos
messages: + msg2882
assignedto: markstos
2008-02-02 03:06:45markstossetstatus: unknown -> has-patch
nosy: droundy, tommy, beschmi, kowey, markstos, trentbuck
messages: + msg3053
assignedto: markstos -> trentbuck
2008-02-02 10:46:08trentbucksetfiles: + add-functional-sh-test-for-issue496_.dpatch, unnamed
nosy: droundy, tommy, beschmi, kowey, markstos, trentbuck
messages: + msg3056
title: _darcs/prefs/defaults ignored when using --repodir -> functional test patch bundle
2008-02-02 16:06:15markstossetnosy: droundy, tommy, beschmi, kowey, markstos, trentbuck
assignedto: trentbuck -> markstos
title: functional test patch bundle -> _darcs/prefs/defaults ignored when using --repodir
2008-02-02 16:34:12markstossettopic: + Confirmed, Patch, Darcs2, IncludesExampleOrTest
nosy: droundy, tommy, beschmi, kowey, markstos, trentbuck
messages: + msg3059
assignedto: markstos ->
2008-02-15 20:27:35droundysetstatus: has-patch -> resolved-in-unstable
nosy: + darcs-bugs
messages: + msg3456
title: _darcs/prefs/defaults ignored when using --repodir -> delayed the check for --disabled until after reading defaults.
2008-09-04 21:31:10adminsetstatus: resolved-in-unstable -> resolved
nosy: + dagit
2009-08-06 17:34:32adminsetnosy: + jast, Serware, dmitry.kurochkin, darcs-devel, zooko, mornfall, simon, thorkilnaur, - droundy, trentbuck, darcs-bugs
2009-08-06 20:31:52adminsetnosy: - beschmi
2009-08-10 22:06:07adminsetnosy: + darcs-bugs, trentbuck, - darcs-devel, zooko, jast, Serware, mornfall
2009-08-11 00:01:31adminsetnosy: - dagit
2009-08-25 17:49:07adminsetnosy: + darcs-devel, - simon
2009-08-27 14:07:02adminsetnosy: tommy, kowey, markstos, darcs-devel, trentbuck, thorkilnaur, darcs-bugs, dmitry.kurochkin